add crossreference to bug #603
authorLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Sat, 20 Feb 2021 21:55:57 +0000 (21:55 +0000)
committerLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Sat, 20 Feb 2021 21:55:57 +0000 (21:55 +0000)
src/soc/decoder/power_decoder2.py

index 8c34db7e6e164576b8952d68f1ee2f34b72fd89a..6cf06f34c677591e573d942d33272c30ded3ebf1 100644 (file)
@@ -917,6 +917,10 @@ class PowerDecodeSubset(Elaboratable):
         spr = Signal(10, reset_less=True)
         comb += spr.eq(decode_spr_num(self.dec.SPR)) # from XFX
 
+        # XXX BUG - don't use hardcoded magic constants.
+        # also use ".value" otherwise the test fails.  bit of a pain
+        # https://bugs.libre-soc.org/show_bug.cgi?id=603
+
         SPR_PID   = 48  # TODO read docs for POWER9
         # Microwatt doesn't implement the partition table
         # instead has PRTBL register (SPR) to point to process table