another batch of ready/valid i/o prefix-suffix swaps
authorLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Fri, 3 Sep 2021 07:13:14 +0000 (08:13 +0100)
committerLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Fri, 3 Sep 2021 07:13:14 +0000 (08:13 +0100)
src/soc/fu/branch/test/test_pipe_caller.py
src/soc/fu/compunits/formal/proof_fu.py
src/soc/fu/mmu/test/test_non_production_core.py
src/soc/fu/mmu/test/test_pipe_caller.py
src/soc/fu/spr/test/test_pipe_caller.py
src/soc/fu/trap/test/test_pipe_caller.py

index 0c5b3b9573b8b7ee6bc3c555b806937e2f2854e3..0b701ae85b0ddcc550cf8f1dfe1a68a4c086d4cf 100644 (file)
@@ -74,8 +74,8 @@ class TestRunner(unittest.TestCase):
         m.submodules.branch = branch = BranchBasePipe(pspec)
 
         comb += branch.p.i_data.ctx.op.eq_from_execute1(pdecode2.do)
-        comb += branch.p.valid_i.eq(1)
-        comb += branch.n.ready_i.eq(1)
+        comb += branch.p.i_valid.eq(1)
+        comb += branch.n.i_ready.eq(1)
         comb += pdecode2.dec.raw_opcode_in.eq(instruction)
         sim = Simulator(m)
 
index 06437df0a4e8d8e28c757470dd0fb751eb753a02..9ec497fa7060a41fe21c6429a3235ab1fb035792 100644 (file)
@@ -114,12 +114,12 @@ class Driver(Elaboratable):
             alu_temp = Signal(16)
             write_req_valid = Signal(reset=0)
             with m.If(~Past(go_die) & Past(busy)):
-                with m.If(Rose(dut.alu.n.valid_o)):
+                with m.If(Rose(dut.alu.n.o_valid)):
                     sync += alu_temp.eq(dut.alu.o)
                     sync += write_req_valid.eq(1)
 
             # write_req_valid should only be high once the alu finishes
-            with m.If(~write_req_valid & ~dut.alu.n.valid_o):
+            with m.If(~write_req_valid & ~dut.alu.n.o_valid):
                 comb += Assert(wr_rel == 0)
 
             # Property 6: Write request release is held up if shadow_n
@@ -218,7 +218,7 @@ class FUTestCase(FHDLTestCase):
                     'oper_i_None__insn_type', 'i1[15:0]',
                     'i_valid', 'o_ready']),
                 ('next port', 'out', [
-                    'alu_o[15:0]', 'valid_o', 'ready_i'])])]
+                    'alu_o[15:0]', 'o_valid', 'i_ready'])])]
 
         write_gtkw('test_fu_formal_bmc.gtkw',
                    os.path.dirname(__file__) +
index 5a77a455c10b78417cd9b7939ac8a3cdd0081fe9..dc7d5c62846ee252cb3784d71d8d6e3e85e3a67e 100644 (file)
@@ -102,11 +102,11 @@ class TestRunner(unittest.TestCase):
 
             fsm = core.fus.fus["mmu0"].alu
 
-            vld = yield fsm.n.valid_o
+            vld = yield fsm.n.o_valid
             while not vld:
                 yield
                 if debughang:  print("not valid -- hang")
-                vld = yield fsm.n.valid_o
+                vld = yield fsm.n.o_valid
                 if debughang==2: vld=1
             yield
 
index 10c4b048183745b20def12d02f2f8443455f8ca3..0bb9f4f9ecaf0f888fe8c636033ba2be1892e46b 100644 (file)
@@ -189,13 +189,13 @@ class TestRunner(unittest.TestCase):
             index = pc//4
             print("pc after %08x" % (pc))
 
-            vld = yield fsm.n.valid_o #fsm
+            vld = yield fsm.n.o_valid #fsm
             while not vld:
                 yield
                 if debughang:
                     print("not valid -- hang")
                     return
-                vld = yield fsm.n.valid_o
+                vld = yield fsm.n.o_valid
                 if debughang==2: vld=1
             yield
 
@@ -225,8 +225,8 @@ class TestRunner(unittest.TestCase):
         #FIXME connect fsm inputs
 
         comb += fsm.p.i_data.ctx.op.eq_from_execute1(pdecode2.do)
-        comb += fsm.p.valid_i.eq(1)
-        comb += fsm.n.ready_i.eq(1)
+        comb += fsm.p.i_valid.eq(1)
+        comb += fsm.n.i_ready.eq(1)
         comb += pdecode2.dec.raw_opcode_in.eq(instruction)
         sim = Simulator(m)
 
index fbe2314db96580091989b3ae8fb3c4dcc729bfe7..d6aa34ea6b972ca0b68b34030f74dc0a9212ab47 100644 (file)
@@ -122,10 +122,10 @@ class TestRunner(unittest.TestCase):
             index = pc//4
             print("pc after %08x" % (pc))
 
-            vld = yield alu.n.valid_o
+            vld = yield alu.n.o_valid
             while not vld:
                 yield
-                vld = yield alu.n.valid_o
+                vld = yield alu.n.o_valid
             yield
 
             yield from self.check_alu_outputs(alu, pdecode2, sim, code)
@@ -143,8 +143,8 @@ class TestRunner(unittest.TestCase):
         m.submodules.alu = alu = SPRBasePipe(pspec)
 
         comb += alu.p.i_data.ctx.op.eq_from_execute1(pdecode2.do)
-        comb += alu.p.valid_i.eq(1)
-        comb += alu.n.ready_i.eq(1)
+        comb += alu.p.i_valid.eq(1)
+        comb += alu.n.i_ready.eq(1)
         comb += pdecode2.dec.raw_opcode_in.eq(instruction)
         sim = Simulator(m)
 
index 71ed8277f5f63fcddb7dd881ef5c8738f5d9d6c7..a634bc0570784ed31eb4f77059f2936fe5a67b8c 100644 (file)
@@ -91,8 +91,8 @@ class TestRunner(unittest.TestCase):
         m.submodules.alu = alu = TrapBasePipe(pspec)
 
         comb += alu.p.i_data.ctx.op.eq_from_execute1(pdecode2.do)
-        comb += alu.p.valid_i.eq(1)
-        comb += alu.n.ready_i.eq(1)
+        comb += alu.p.i_valid.eq(1)
+        comb += alu.n.i_ready.eq(1)
         comb += pdecode2.dec.raw_opcode_in.eq(instruction)
         sim = Simulator(m)
 
@@ -142,10 +142,10 @@ class TestRunner(unittest.TestCase):
                         msr = sim.msr.value
                         print("msr after %08x" % (msr))
 
-                        vld = yield alu.n.valid_o
+                        vld = yield alu.n.o_valid
                         while not vld:
                             yield
-                            vld = yield alu.n.valid_o
+                            vld = yield alu.n.o_valid
                         yield
 
                         yield from self.check_alu_outputs(alu, pdecode2,