projects / mesa.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 62de79a)
ci: Don't call renderdoc's ReplayController.Shutdown()
authorTomeu Vizoso <tomeu.vizoso@collabora.com>
Tue, 14 Apr 2020 13:57:08 +0000 (15:57 +0200)
committerMarge Bot <eric+marge@anholt.net>
Thu, 25 Jun 2020 17:33:28 +0000 (17:33 +0000)
If we do, Renderdoc will call eglDestroyContext twice, causing crashes
within Mesa.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5433>

.gitlab-ci/tracie/renderdoc_dump_images.py patch | blob | history

diff --git a/.gitlab-ci/tracie/renderdoc_dump_images.py b/.gitlab-ci/tracie/renderdoc_dump_images.py
index 93e24b9ca252ff9ee100d6e70070171c2dbd7b76..a89b5fda7947d76baacb10801502520d84e37b96 100755 (executable)
--- a/.gitlab-ci/tracie/renderdoc_dump_images.py
+++ b/.gitlab-ci/tracie/renderdoc_dump_images.py
@@ -112,7 +112,6 @@ def renderdoc_dump_images(filename, eventIds, outputDir):
    for eventId in eventIds:
       dumpImage(controller, eventId, outputDir, tracefile)
 
-   controller.Shutdown()
    cap.Shutdown()
 
    rd.ShutdownReplay()