radv: Add render loop detection in renderpass.

VK spec 7.3:

"Applications must ensure that all accesses to memory that backs
image subresources used as attachments in a given renderpass instance
either happen-before the load operations for those attachments, or
happen-after the store operations for those attachments."

So the only renderloops we can have is with input attachments. Detect
these.

Reviewed-by: Dave Airlie <airlied@redhat.com>

diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
index 688a17919bd482d1be660fe33afbdb03596bd3fd..2b60a25535a4c28ecbfdc0513d6a38df8f16e8b3 100644 (file)
--- a/src/amd/vulkan/radv_pass.c
+++ b/src/amd/vulkan/radv_pass.c
@@ -148,6 +148,24 @@ radv_render_pass_compile(struct radv_render_pass *pass)
                                subpass->has_color_resolve = true;
                        }
                }
+
+               for (uint32_t j = 0; j < subpass->input_count; ++j) {
+                       if (subpass->input_attachments[j].attachment == VK_ATTACHMENT_UNUSED)
+                               continue;
+
+                       for (uint32_t k = 0; k < subpass->color_count; ++k) {
+                               if (subpass->color_attachments[k].attachment == subpass->input_attachments[j].attachment) {
+                                       subpass->input_attachments[j].in_render_loop = true;
+                                       subpass->color_attachments[k].in_render_loop = true;
+                               }
+                       }
+
+                       if (subpass->depth_stencil_attachment &&
+                           subpass->depth_stencil_attachment->attachment == subpass->input_attachments[j].attachment) {
+                               subpass->input_attachments[j].in_render_loop = true;
+                               subpass->depth_stencil_attachment->in_render_loop = true;
+                       }
+               }
        }
 }
 

diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
index c0d30d747f4ef993826d75058e108516f3abad8e..ac5945cab573075e0be293dbdc275eea7c7fe0fb 100644 (file)
--- a/src/amd/vulkan/radv_private.h
+++ b/src/amd/vulkan/radv_private.h
@@ -1971,6 +1971,7 @@ void radv_subpass_barrier(struct radv_cmd_buffer *cmd_buffer,
 struct radv_subpass_attachment {
        uint32_t         attachment;
        VkImageLayout    layout;
+       bool             in_render_loop;
 };
 
 struct radv_subpass {