mesa.git
14 years agoeglinfo: Wrap extension string
Kristian Høgsberg [Fri, 26 Feb 2010 20:11:29 +0000 (15:11 -0500)]
eglinfo: Wrap extension string

14 years agoxeglgears: Add an case that exercises EGL_KHR_gl_renderbuffer_image
Kristian Høgsberg [Fri, 26 Feb 2010 19:51:32 +0000 (14:51 -0500)]
xeglgears: Add an case that exercises EGL_KHR_gl_renderbuffer_image

14 years agoegl_dri2: Implement EGL_KHR_gl_renderbuffer_image
Kristian Høgsberg [Fri, 26 Feb 2010 19:51:11 +0000 (14:51 -0500)]
egl_dri2: Implement EGL_KHR_gl_renderbuffer_image

14 years agointel: Lookup requested renderbuffer in intel_create_image_from_renderbuffer
Kristian Høgsberg [Fri, 26 Feb 2010 19:49:31 +0000 (14:49 -0500)]
intel: Lookup requested renderbuffer in intel_create_image_from_renderbuffer

Previously we'd use the current renderbuffer.

14 years agoprogs/tests: add compile-time option for coloring texture corners
Brian Paul [Fri, 26 Feb 2010 19:04:53 +0000 (12:04 -0700)]
progs/tests: add compile-time option for coloring texture corners

When debugging wrap modes it's helpful to set each corner of the texture
image to a distinct color.

14 years agogallium: define GENERATED auxiliary files
Brian Paul [Fri, 26 Feb 2010 18:58:54 +0000 (11:58 -0700)]
gallium: define GENERATED auxiliary files

Don't need special default dependency on u_format_pack.h anymore.

14 years agogallium: added GENERATED_SOURCES var to Makefile.template
Brian Paul [Fri, 26 Feb 2010 18:58:05 +0000 (11:58 -0700)]
gallium: added GENERATED_SOURCES var to Makefile.template

For use in dependency checking and make clean.

14 years agoprogs/glsl: Ensure CFLAGS are passed during linking
Dan Nicholson [Fri, 26 Feb 2010 18:01:37 +0000 (10:01 -0800)]
progs/glsl: Ensure CFLAGS are passed during linking

Commit ab6825b3e3fd04564b7840e945fa32b0a7b3c0c2 fixed an issue where the
architecture option -m32 wasn't being passed to the compiler when
linking .o files. This would only fix the issue with user's building
with the hacky --enable-32-bit. The right way to fix this is to pass
CFLAGS to the linker, which the GNU make builtin rules unfortunately
don't do.

Signed-off-by: Dan Nicholson <dbn.lists@gmail.com>
Tested-by: Török Edwin <edwintorok@gmail.com>
14 years agoxeglgears: Clean up the code a bit
Kristian Høgsberg [Fri, 26 Feb 2010 18:18:37 +0000 (13:18 -0500)]
xeglgears: Clean up the code a bit

Still a mess...

14 years agoSet API dispatch pointers for OES_EGL_image functions
Kristian Høgsberg [Fri, 26 Feb 2010 18:17:30 +0000 (13:17 -0500)]
Set API dispatch pointers for OES_EGL_image functions

This chunk fell through the cracks when I rebase the EGLImage patch series.

14 years agoRevert "gallium: remove unneeded -I path from Makefile.templast"
Brian Paul [Fri, 26 Feb 2010 17:54:20 +0000 (10:54 -0700)]
Revert "gallium: remove unneeded -I path from Makefile.templast"

This reverts commit d9c65ddd52199469c49fc0d3ad90fedb9a69274d.

Looks like the nouveau drivers need this.  Perhaps the drivers
could be fixed to add the extra -I path where needed.  I'll leave
that up to others.

14 years agogallium/nouveau: clean-up #includes
Brian Paul [Fri, 26 Feb 2010 17:54:05 +0000 (10:54 -0700)]
gallium/nouveau: clean-up #includes

14 years agogallium: remove unneeded -I path from Makefile.templast
Brian Paul [Fri, 26 Feb 2010 17:44:41 +0000 (10:44 -0700)]
gallium: remove unneeded -I path from Makefile.templast

14 years agosoftpipe: fix up #includes
Brian Paul [Fri, 26 Feb 2010 17:43:56 +0000 (10:43 -0700)]
softpipe: fix up #includes

14 years agogallium/trace: remove unneeded path prefixes on #includes
Brian Paul [Fri, 26 Feb 2010 17:43:19 +0000 (10:43 -0700)]
gallium/trace: remove unneeded path prefixes on #includes

14 years agogallium/identity: remove unneeded path prefixes on #includes
Brian Paul [Fri, 26 Feb 2010 17:43:04 +0000 (10:43 -0700)]
gallium/identity: remove unneeded path prefixes on #includes

14 years agoglx: fix incorrect array stack memory allocation
Markus Fleschutz [Fri, 26 Feb 2010 17:34:19 +0000 (10:34 -0700)]
glx: fix incorrect array stack memory allocation

The array stack space wasn't allocated to the proper size.  Fixes out of
bounds memory writes when the client/array stack depth exceeds one.

See fd.o bug 26768.

14 years agoutil: Define SRGB's channels as normalized.
José Fonseca [Fri, 26 Feb 2010 16:46:09 +0000 (16:46 +0000)]
util: Define SRGB's channels as normalized.

A better approximation than uscaled...

14 years agoutil: Code generate functions to pack and unpack a single pixel.
José Fonseca [Fri, 26 Feb 2010 16:45:22 +0000 (16:45 +0000)]
util: Code generate functions to pack and unpack a single pixel.

Should work correctly for all pixel formats except SRGB formats.

Generated code made much simpler by defining the pixel format as
a C structure. For example this is the generated structure for
PIPE_FORMAT_B6UG5SR5S_NORM:

union util_format_b6ug5sr5s_norm {
   uint16_t value;
   struct {
      int r:5;
      int g:5;
      unsigned b:6;
   } chan;
};

Not used everywhere yet because it seems compiled code is slower than
bitshift arithmetic by some misterious reason. So we should generate
bitshift arithmetic at least for the simple UNORM pixel formats.

14 years agoutil: Factor some code into u_format_parse.py
José Fonseca [Fri, 26 Feb 2010 15:45:48 +0000 (15:45 +0000)]
util: Factor some code into u_format_parse.py

14 years agoutil: Add util_bswap16.
José Fonseca [Fri, 26 Feb 2010 15:37:18 +0000 (15:37 +0000)]
util: Add util_bswap16.

14 years agoutil: Use python names consistent with u_format.h
José Fonseca [Fri, 26 Feb 2010 11:03:06 +0000 (11:03 +0000)]
util: Use python names consistent with u_format.h

14 years agomesa: fix _BaseFormat assignment in _mesa_soft_renderbuffer_storage()
Brian Paul [Fri, 26 Feb 2010 16:03:31 +0000 (09:03 -0700)]
mesa: fix _BaseFormat assignment in _mesa_soft_renderbuffer_storage()

The rb->InternalFormat field will be set by the caller if the allocation
succeeds.  Until then, this field's value can't be used.  Fixes a failed
assertion with FlightGear.

14 years agomesa: update tarball file list, bump version string
Brian Paul [Fri, 26 Feb 2010 15:21:44 +0000 (08:21 -0700)]
mesa: update tarball file list, bump version string

14 years agoprogs/xdemos: fix typo in glxinfo help
Brian Paul [Fri, 26 Feb 2010 15:17:37 +0000 (08:17 -0700)]
progs/xdemos: fix typo in glxinfo help

14 years agollvmpipe: Fix lp_tile_r5g6b5_unorm_write_4ub.
José Fonseca [Fri, 26 Feb 2010 10:12:32 +0000 (10:12 +0000)]
llvmpipe: Fix lp_tile_r5g6b5_unorm_write_4ub.

Was using 32bit integer pointers instead of 16bits.

14 years agollvmpipe: Fix scons dependencies.
José Fonseca [Fri, 26 Feb 2010 10:11:52 +0000 (10:11 +0000)]
llvmpipe: Fix scons dependencies.

14 years agoutil: Add is_pot() method to formats.
José Fonseca [Fri, 26 Feb 2010 10:11:36 +0000 (10:11 +0000)]
util: Add is_pot() method to formats.

14 years agoFix up more stale references to gl(X)_API.xml which have moved.
Michel Dänzer [Fri, 26 Feb 2010 09:48:07 +0000 (10:48 +0100)]
Fix up more stale references to gl(X)_API.xml which have moved.

AFAICT the getproc* stanzas in progs/{fp,trivial}/Makefile are completely
unused at this point, so just remove them.

14 years agofix test progs from gl_API move
Wil Reichert [Fri, 26 Feb 2010 09:48:06 +0000 (10:48 +0100)]
fix test progs from gl_API move

Looks like these got missed.

14 years agoRevert "glapi: Remove unnecessary headers."
José Fonseca [Fri, 26 Feb 2010 09:09:35 +0000 (09:09 +0000)]
Revert "glapi: Remove unnecessary headers."

This reverts commit ead22e6a328e7d7b7c0b52af4705634e989e4d69.

This headers are not unnecessary on windows.

14 years agor300/compiler: Assert that array index is not negative.
Vinson Lee [Fri, 26 Feb 2010 08:17:03 +0000 (00:17 -0800)]
r300/compiler: Assert that array index is not negative.

14 years agoglapi: Remove unnecessary headers.
Vinson Lee [Fri, 26 Feb 2010 07:58:45 +0000 (23:58 -0800)]
glapi: Remove unnecessary headers.

14 years agoi965: Remove unnecessary headers.
Vinson Lee [Fri, 26 Feb 2010 07:51:05 +0000 (23:51 -0800)]
i965: Remove unnecessary headers.

14 years agoswrast: add 0.5 bias in tex_array_slice() per the spec
Brian Paul [Fri, 26 Feb 2010 03:21:39 +0000 (20:21 -0700)]
swrast: add 0.5 bias in tex_array_slice() per the spec

14 years agodocs: GL_EXT_texture_array updates
Brian Paul [Fri, 26 Feb 2010 02:50:09 +0000 (19:50 -0700)]
docs: GL_EXT_texture_array updates

14 years agomesa: enable GL_EXT_texture_array for sw drivers
Brian Paul [Fri, 26 Feb 2010 02:48:57 +0000 (19:48 -0700)]
mesa: enable GL_EXT_texture_array for sw drivers

14 years agoglsl: implement support for GL_EXT_texture_array
Brian Paul [Fri, 26 Feb 2010 02:45:45 +0000 (19:45 -0700)]
glsl: implement support for GL_EXT_texture_array

GL_EXT_texture_array is different from the existing GL_MESA_texture_array
support in that the former is only supported for GLSL, not fixed-function.

The shadow compare versions of the sampler functions haven't been tested
yet.  The non-shadow versions have been tested with a new piglit test.

14 years agomesa: added new extension flag for GL_EXT_texture_array
Brian Paul [Fri, 26 Feb 2010 02:08:02 +0000 (19:08 -0700)]
mesa: added new extension flag for GL_EXT_texture_array

14 years agoswrast: the only wrap mode for selecting texture array slices is clamp
Brian Paul [Fri, 26 Feb 2010 02:06:27 +0000 (19:06 -0700)]
swrast: the only wrap mode for selecting texture array slices is clamp

14 years agomesa: added texture array targets in sizeof_glsl_type()
Brian Paul [Fri, 26 Feb 2010 02:05:11 +0000 (19:05 -0700)]
mesa: added texture array targets in sizeof_glsl_type()

14 years agomesa: added cases for texture array targets
Brian Paul [Fri, 26 Feb 2010 02:04:21 +0000 (19:04 -0700)]
mesa: added cases for texture array targets

14 years agomesa: remove redundant call to _mesa_base_fbo_format()
Brian Paul [Fri, 26 Feb 2010 02:03:55 +0000 (19:03 -0700)]
mesa: remove redundant call to _mesa_base_fbo_format()

14 years agomesa: added renderbuffer->_BaseFormat assertion
Brian Paul [Fri, 26 Feb 2010 02:03:24 +0000 (19:03 -0700)]
mesa: added renderbuffer->_BaseFormat assertion

14 years agoi965: Try to hook up the Sandybridge URB_WRITE SEND message.
Eric Anholt [Fri, 26 Feb 2010 02:35:08 +0000 (18:35 -0800)]
i965: Try to hook up the Sandybridge URB_WRITE SEND message.

My units still hang when doing this if the VS is enabled.

14 years agoi965: Fix up the VUE handling for SNB, and hopefully clarify comments.
Eric Anholt [Fri, 26 Feb 2010 01:58:04 +0000 (17:58 -0800)]
i965: Fix up the VUE handling for SNB, and hopefully clarify comments.

14 years agoi965: Don't set a nonexistent enable bit in several SNB state pointers.
Eric Anholt [Fri, 26 Feb 2010 00:25:17 +0000 (16:25 -0800)]
i965: Don't set a nonexistent enable bit in several SNB state pointers.

The modify bit is now usually in the instruction header.  The
exception is CC state pointers.

14 years agoi965: Lump SNB in with Ironlake for bigger VUEs.
Eric Anholt [Thu, 25 Feb 2010 23:23:13 +0000 (15:23 -0800)]
i965: Lump SNB in with Ironlake for bigger VUEs.

This gets the VS to the point of accepting vertices.  \o/

14 years agoi965: Fix the SNB VE valid bit.
Eric Anholt [Thu, 25 Feb 2010 23:22:20 +0000 (15:22 -0800)]
i965: Fix the SNB VE valid bit.

So, when the docs say that 0 means enabled now?  That's a lie.

14 years agointel: Fix up INTEL_NO_HW support.
Eric Anholt [Thu, 25 Feb 2010 22:27:07 +0000 (14:27 -0800)]
intel: Fix up INTEL_NO_HW support.

This was accidentally (it seems) deleted in
5203b7227ccb6b618fa42f08434d4a3cf123dca2

14 years agoi965: Don't include SNB in has_negative_rhw_bug.
Eric Anholt [Thu, 25 Feb 2010 22:24:36 +0000 (14:24 -0800)]
i965: Don't include SNB in has_negative_rhw_bug.

14 years agoi965: Fix the SNB clip near VP API bit.
Eric Anholt [Thu, 25 Feb 2010 22:05:27 +0000 (14:05 -0800)]
i965: Fix the SNB clip near VP API bit.

14 years agoi965: Fix the SNB URB entry count setup.
Eric Anholt [Thu, 25 Feb 2010 21:46:45 +0000 (13:46 -0800)]
i965: Fix the SNB URB entry count setup.

14 years agodrop header files and demos for dropped window systems
George Sapountzis [Fri, 26 Feb 2010 02:02:41 +0000 (04:02 +0200)]
drop header files and demos for dropped window systems

14 years agoremove hack for miniglx from dri/utils.c
George Sapountzis [Fri, 26 Feb 2010 02:02:41 +0000 (04:02 +0200)]
remove hack for miniglx from dri/utils.c

14 years agodrop linux-solo configs
George Sapountzis [Fri, 26 Feb 2010 02:02:41 +0000 (04:02 +0200)]
drop linux-solo configs

14 years agominor cleanup of dri/Makefile.template's after miniglx drop
George Sapountzis [Fri, 26 Feb 2010 02:02:41 +0000 (04:02 +0200)]
minor cleanup of dri/Makefile.template's after miniglx drop

also makes the WINDOW_SYSTEM configure var useless ...

14 years agodrop stray src/mesa/main/sources
George Sapountzis [Fri, 26 Feb 2010 02:02:40 +0000 (04:02 +0200)]
drop stray src/mesa/main/sources

14 years agomesa: use simplified _BaseFormat value in render-to-texture code
Brian Paul [Fri, 26 Feb 2010 01:59:56 +0000 (18:59 -0700)]
mesa: use simplified _BaseFormat value in render-to-texture code

Fixes fd.o bug 26762.

14 years agoutil: remove a trailing semicolon in format table code
Brian Paul [Thu, 25 Feb 2010 23:20:01 +0000 (16:20 -0700)]
util: remove a trailing semicolon in format table code

14 years agoprogs/glsl: add ARCH_FLAGS to LDLIBS
Török Edvin [Thu, 25 Feb 2010 16:02:43 +0000 (09:02 -0700)]
progs/glsl: add ARCH_FLAGS to LDLIBS

Allows building 32-bit demos on 64-bit Debian host.

Signed-off-by: Brian Paul <brianp@vmware.com>
14 years agoutil: Remove import of unused sys module.
Vinson Lee [Fri, 26 Feb 2010 01:52:48 +0000 (17:52 -0800)]
util: Remove import of unused sys module.

14 years agoRemove unused mini and mesa glu subdirectories
Kristian Høgsberg [Thu, 25 Feb 2010 21:20:03 +0000 (16:20 -0500)]
Remove unused mini and mesa glu subdirectories

14 years agoDrop unused glut subdirectories
Kristian Høgsberg [Thu, 25 Feb 2010 21:19:20 +0000 (16:19 -0500)]
Drop unused glut subdirectories

14 years agoRemove windml progs
Kristian Høgsberg [Thu, 25 Feb 2010 21:17:40 +0000 (16:17 -0500)]
Remove windml progs

14 years agoRemove remaining miniglx references
Kristian Høgsberg [Thu, 25 Feb 2010 21:17:04 +0000 (16:17 -0500)]
Remove remaining miniglx references

14 years agoDrop fb, ffb and gamma dri drivers
Kristian Høgsberg [Thu, 25 Feb 2010 21:12:58 +0000 (16:12 -0500)]
Drop fb, ffb and gamma dri drivers

14 years agoDrop classic mesa svga driver
Kristian Høgsberg [Thu, 25 Feb 2010 21:10:09 +0000 (16:10 -0500)]
Drop classic mesa svga driver

14 years agoDrop glide driver
Kristian Høgsberg [Thu, 25 Feb 2010 21:08:59 +0000 (16:08 -0500)]
Drop glide driver

14 years agoRemove GGI support
Kristian Høgsberg [Thu, 25 Feb 2010 21:00:45 +0000 (16:00 -0500)]
Remove GGI support

14 years agoRemove dos driver
Kristian Høgsberg [Thu, 25 Feb 2010 20:55:00 +0000 (15:55 -0500)]
Remove dos driver

14 years agoRemove d3d driver
Kristian Høgsberg [Thu, 25 Feb 2010 20:52:32 +0000 (15:52 -0500)]
Remove d3d driver

14 years agoRemove directfb support
Kristian Høgsberg [Thu, 25 Feb 2010 20:49:18 +0000 (15:49 -0500)]
Remove directfb support

14 years agoRemove allegro driver
Kristian Høgsberg [Thu, 25 Feb 2010 20:50:52 +0000 (15:50 -0500)]
Remove allegro driver

14 years agoRevert "glu/sgi: Set freed pointer to NULL."
Vinson Lee [Thu, 25 Feb 2010 22:26:25 +0000 (14:26 -0800)]
Revert "glu/sgi: Set freed pointer to NULL."

This commit breaks flightgear fgfs. A null pointer is
dereferenced in the function MakeVertex.

This reverts commit 9be414f4b93c763e1aee8f634a13721ae5d95fcd.

14 years agoMerge branch 'sandybridge'
Eric Anholt [Thu, 25 Feb 2010 18:56:09 +0000 (10:56 -0800)]
Merge branch 'sandybridge'

This brings in the initial code I've been working on for bringing up
OpenGL on Sandybridge in the i965 driver.  It doesn't work yet.

14 years agodocs: addition of ARB_fcc to i965.
Eric Anholt [Tue, 23 Feb 2010 19:18:25 +0000 (11:18 -0800)]
docs: addition of ARB_fcc to i965.

14 years agoi965: Add SNB math opcode support.
Eric Anholt [Wed, 24 Feb 2010 17:16:19 +0000 (09:16 -0800)]
i965: Add SNB math opcode support.

This is untested at this point.

14 years agoi965: Emit SNB FF unit state after the unit's push constants.
Eric Anholt [Wed, 24 Feb 2010 01:42:20 +0000 (17:42 -0800)]
i965: Emit SNB FF unit state after the unit's push constants.

There's a BUN for the WM unit that says WM_STATE must immediately
follow PS_CONSTANTS, which this addresses.  Presumably other units are
roughly the same, too.

14 years agoi965: Set up the SNB sampler state pointers.
Eric Anholt [Mon, 1 Feb 2010 17:55:18 +0000 (09:55 -0800)]
i965: Set up the SNB sampler state pointers.

14 years agoi965: Set GS rendering enabled even when the GS stage is disabled.
Eric Anholt [Mon, 1 Feb 2010 17:41:26 +0000 (09:41 -0800)]
i965: Set GS rendering enabled even when the GS stage is disabled.

This is copying the behavior of other drivers.

14 years agoi965: Add a couple SNB state packets I saw in other batchbuffer dumps.
Eric Anholt [Mon, 1 Feb 2010 17:04:12 +0000 (09:04 -0800)]
i965: Add a couple SNB state packets I saw in other batchbuffer dumps.

14 years agoi965: Re-disable the VS.
Eric Anholt [Mon, 25 Jan 2010 22:48:06 +0000 (14:48 -0800)]
i965: Re-disable the VS.

There's stuff that needs to happen in the ISA before we can play with
actually executing anything in the VS.

14 years agoi965: Fix up some Sandybridge define checks for the structure rebase.
Eric Anholt [Mon, 21 Dec 2009 22:28:18 +0000 (14:28 -0800)]
i965: Fix up some Sandybridge define checks for the structure rebase.

14 years agoi965: Move PIPELINE_SELECT to the top of gen6 3d pipeline setup.
Eric Anholt [Mon, 21 Dec 2009 21:08:41 +0000 (13:08 -0800)]
i965: Move PIPELINE_SELECT to the top of gen6 3d pipeline setup.

14 years agoi965: Untested Sandybridge WM packets.
Eric Anholt [Mon, 21 Dec 2009 19:48:32 +0000 (11:48 -0800)]
i965: Untested Sandybridge WM packets.

14 years agoi965: Hook up remaining Sandybridge state packets besides WM.
Eric Anholt [Mon, 21 Dec 2009 19:22:14 +0000 (11:22 -0800)]
i965: Hook up remaining Sandybridge state packets besides WM.

14 years agoi965: Untested Sandybridge SF setup.
Eric Anholt [Fri, 29 Jan 2010 19:03:04 +0000 (11:03 -0800)]
i965: Untested Sandybridge SF setup.

14 years agoi965: Fixup Sandybridge GS packet from doc updates.
Eric Anholt [Fri, 18 Dec 2009 02:41:18 +0000 (18:41 -0800)]
i965: Fixup Sandybridge GS packet from doc updates.

14 years agoi965: Fix up Sandybridge GS reg definitions
Eric Anholt [Thu, 17 Dec 2009 23:52:17 +0000 (15:52 -0800)]
i965: Fix up Sandybridge GS reg definitions

14 years agoi965: fix typo in SNB VS defines comment
Eric Anholt [Thu, 17 Dec 2009 23:51:43 +0000 (15:51 -0800)]
i965: fix typo in SNB VS defines comment

14 years agoi965: fix typo in SNB GS register defines
Eric Anholt [Thu, 17 Dec 2009 22:51:42 +0000 (14:51 -0800)]
i965: fix typo in SNB GS register defines

14 years agoi965: Enable clip stats.
Eric Anholt [Thu, 17 Dec 2009 17:47:53 +0000 (09:47 -0800)]
i965: Enable clip stats.

14 years agoi965: Add Sandybridge viewport setup.
Eric Anholt [Thu, 17 Dec 2009 17:38:50 +0000 (09:38 -0800)]
i965: Add Sandybridge viewport setup.

14 years agoi965: Enable DRAWING_RECTANGLE emit on Sandybridge.
Eric Anholt [Thu, 17 Dec 2009 16:23:37 +0000 (08:23 -0800)]
i965: Enable DRAWING_RECTANGLE emit on Sandybridge.

14 years agoi965: Add Sandybridge scissor state.
Eric Anholt [Thu, 17 Dec 2009 16:20:32 +0000 (08:20 -0800)]
i965: Add Sandybridge scissor state.

14 years agoi965: Fix up the VF stats packet header.
Eric Anholt [Mon, 14 Dec 2009 22:17:00 +0000 (14:17 -0800)]
i965: Fix up the VF stats packet header.

14 years agoi965: Set the state base address on Sandybridge.
Eric Anholt [Mon, 14 Dec 2009 22:11:14 +0000 (14:11 -0800)]
i965: Set the state base address on Sandybridge.

14 years agoi965: Free gen6 state BOs on context destroy.
Eric Anholt [Fri, 4 Dec 2009 02:52:35 +0000 (18:52 -0800)]
i965: Free gen6 state BOs on context destroy.

14 years agoi965: Giant pile of flushing to track down SNB bringup issues.
Eric Anholt [Fri, 29 Jan 2010 18:42:17 +0000 (10:42 -0800)]
i965: Giant pile of flushing to track down SNB bringup issues.

This should go away before we push the code.