cpu: Remove the ancient do_quiesce config option.
authorGabe Black <gabeblack@google.com>
Wed, 5 Feb 2020 02:41:05 +0000 (18:41 -0800)
committerGabe Black <gabeblack@google.com>
Sat, 23 May 2020 07:04:59 +0000 (07:04 +0000)
This option has existed for a very long time, defaults to True, and is
not used in any of the checked in configs. It enables the "quiesce"
mechanism, originally just pseudo instructions, and it's not clear
why you'd ever want to turn it off.

Change-Id: I92c7e5af22157e8435c7326634857d30bb5d7254
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/25143
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com>
Reviewed-by: Matthew Poremba <matthew.poremba@amd.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/cpu/BaseCPU.py
src/cpu/thread_context.cc

index ab70d1d7f9a851ddd3d5e49493b737582deca61f..e487cbb6bf519f93c0fe6e4209ae223d54420cae 100644 (file)
@@ -149,7 +149,6 @@ class BaseCPU(ClockedObject):
         "enable statistics pseudo instructions")
 
     profile = Param.Latency('0ns', "trace the kernel stack")
-    do_quiesce = Param.Bool(True, "enable quiesce instructions")
 
     wait_for_remote_gdb = Param.Bool(False,
         "Wait for a remote GDB connection");
index de6997a23a56266fad5307e011d752f7475cd0fe..9b93d75493c94e1c67828660c6b0fd2e5bd6e05a 100644 (file)
@@ -130,9 +130,6 @@ ThreadContext::compare(ThreadContext *one, ThreadContext *two)
 void
 ThreadContext::quiesce()
 {
-    if (!getCpuPtr()->params()->do_quiesce)
-        return;
-
     DPRINTF(Quiesce, "%s: quiesce()\n", getCpuPtr()->name());
 
     suspend();
@@ -146,9 +143,6 @@ ThreadContext::quiesceTick(Tick resume)
 {
     BaseCPU *cpu = getCpuPtr();
 
-    if (!cpu->params()->do_quiesce)
-        return;
-
     EndQuiesceEvent *quiesceEvent = getQuiesceEvent();
 
     cpu->reschedule(quiesceEvent, resume, true);