config: Default the indirect branch predictor to "None".
authorGabe Black <gabeblack@google.com>
Wed, 4 Dec 2019 04:33:28 +0000 (20:33 -0800)
committerGabe Black <gabeblack@google.com>
Tue, 17 Dec 2019 00:45:47 +0000 (00:45 +0000)
Other scripts (like se.py) blindly try to apply the indirect predictor
if one is set. Because this option defaults to something, there's no
way (as far as I know) to purposefully select nothing, and so the
simulator crashes. Users shouldn't have to proactively prevent gem5
from killing itself regardless, so the default was changed to "None".

Change-Id: Ic3382b8065442d6705b1c6a656646598d9d5c322
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23360
Reviewed-by: Ciro Santilli <ciro.santilli@arm.com>
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Tested-by: kokoro <noreply+kokoro@google.com>
configs/common/Options.py

index 71d22a4619f0f5b552e801e93097de917936a6aa..173bd483caba11d08a225bdbd65a3eabb5b30d1f 100644 (file)
@@ -183,8 +183,7 @@ def addCommonOptions(parser):
                       type of branch predictor to run with
                       (if not set, use the default branch predictor of
                       the selected CPU)""")
-    parser.add_option("--indirect-bp-type", type="choice",
-                      default="SimpleIndirectPredictor",
+    parser.add_option("--indirect-bp-type", type="choice", default=None,
                       choices=ObjectList.indirect_bp_list.get_names(),
                       help = "type of indirect branch predictor to run with")
     parser.add_option("--list-hwp-types",