v3d: Fix leak of the renderonly struct on screen destruction.
[mesa.git] / src / gallium / drivers / v3d / v3d_screen.c
1 /*
2 * Copyright © 2014-2017 Broadcom
3 * Copyright (C) 2012 Rob Clark <robclark@freedesktop.org>
4 *
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
11 *
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
14 * Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
22 * IN THE SOFTWARE.
23 */
24
25 #include "util/os_misc.h"
26 #include "pipe/p_defines.h"
27 #include "pipe/p_screen.h"
28 #include "pipe/p_state.h"
29
30 #include "util/u_debug.h"
31 #include "util/u_memory.h"
32 #include "util/u_format.h"
33 #include "util/u_hash_table.h"
34 #include "util/u_screen.h"
35 #include "util/u_transfer_helper.h"
36 #include "util/ralloc.h"
37
38 #include <xf86drm.h>
39 #include "v3d_screen.h"
40 #include "v3d_context.h"
41 #include "v3d_resource.h"
42 #include "compiler/v3d_compiler.h"
43
44 static const char *
45 v3d_screen_get_name(struct pipe_screen *pscreen)
46 {
47 struct v3d_screen *screen = v3d_screen(pscreen);
48
49 if (!screen->name) {
50 screen->name = ralloc_asprintf(screen,
51 "V3D %d.%d",
52 screen->devinfo.ver / 10,
53 screen->devinfo.ver % 10);
54 }
55
56 return screen->name;
57 }
58
59 static const char *
60 v3d_screen_get_vendor(struct pipe_screen *pscreen)
61 {
62 return "Broadcom";
63 }
64
65 static void
66 v3d_screen_destroy(struct pipe_screen *pscreen)
67 {
68 struct v3d_screen *screen = v3d_screen(pscreen);
69
70 util_hash_table_destroy(screen->bo_handles);
71 v3d_bufmgr_destroy(pscreen);
72 slab_destroy_parent(&screen->transfer_pool);
73 free(screen->ro);
74
75 if (using_v3d_simulator)
76 v3d_simulator_destroy(screen);
77
78 v3d_compiler_free(screen->compiler);
79 u_transfer_helper_destroy(pscreen->transfer_helper);
80
81 close(screen->fd);
82 ralloc_free(pscreen);
83 }
84
85 static bool
86 v3d_has_feature(struct v3d_screen *screen, enum drm_v3d_param feature)
87 {
88 struct drm_v3d_get_param p = {
89 .param = feature,
90 };
91 int ret = v3d_ioctl(screen->fd, DRM_IOCTL_V3D_GET_PARAM, &p);
92
93 if (ret != 0)
94 return false;
95
96 return p.value;
97 }
98
99 static int
100 v3d_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
101 {
102 struct v3d_screen *screen = v3d_screen(pscreen);
103
104 switch (param) {
105 /* Supported features (boolean caps). */
106 case PIPE_CAP_VERTEX_COLOR_CLAMPED:
107 case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
108 case PIPE_CAP_FRAGMENT_COLOR_CLAMPED:
109 case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
110 case PIPE_CAP_NPOT_TEXTURES:
111 case PIPE_CAP_SHAREABLE_SHADERS:
112 case PIPE_CAP_BLEND_EQUATION_SEPARATE:
113 case PIPE_CAP_TEXTURE_MULTISAMPLE:
114 case PIPE_CAP_TEXTURE_SWIZZLE:
115 case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
116 case PIPE_CAP_START_INSTANCE:
117 case PIPE_CAP_TGSI_INSTANCEID:
118 case PIPE_CAP_SM3:
119 case PIPE_CAP_TEXTURE_QUERY_LOD:
120 case PIPE_CAP_PRIMITIVE_RESTART:
121 case PIPE_CAP_OCCLUSION_QUERY:
122 case PIPE_CAP_POINT_SPRITE:
123 case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
124 case PIPE_CAP_COMPUTE:
125 case PIPE_CAP_DRAW_INDIRECT:
126 case PIPE_CAP_MULTI_DRAW_INDIRECT:
127 case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
128 case PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET:
129 case PIPE_CAP_TGSI_CAN_READ_OUTPUTS:
130 case PIPE_CAP_TGSI_PACK_HALF_FLOAT:
131 case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR:
132 case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT:
133 return 1;
134
135 case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
136 return 0;
137
138 case PIPE_CAP_GENERATE_MIPMAP:
139 return v3d_has_feature(screen, DRM_V3D_PARAM_SUPPORTS_TFU);
140
141 case PIPE_CAP_INDEP_BLEND_ENABLE:
142 return screen->devinfo.ver >= 40;
143
144 case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT:
145 return 256;
146
147 case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS:
148 if (screen->devinfo.ver < 40)
149 return 0;
150 return 4;
151
152 case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
153 return 4;
154
155 case PIPE_CAP_GLSL_FEATURE_LEVEL:
156 return 330;
157
158 case PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY:
159 return 140;
160
161 case PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT:
162 return 1;
163 case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
164 return 0;
165 case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
166 if (screen->devinfo.ver >= 40)
167 return 0;
168 else
169 return 1;
170 case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
171 if (screen->devinfo.ver >= 40)
172 return 1;
173 else
174 return 0;
175
176 case PIPE_CAP_MIXED_FRAMEBUFFER_SIZES:
177 case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
178 case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
179 return 1;
180
181 case PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS:
182 return 4;
183
184 case PIPE_CAP_MAX_VARYINGS:
185 return V3D_MAX_FS_INPUTS / 4;
186
187 /* Texturing. */
188 case PIPE_CAP_MAX_TEXTURE_2D_LEVELS:
189 case PIPE_CAP_MAX_TEXTURE_CUBE_LEVELS:
190 case PIPE_CAP_MAX_TEXTURE_3D_LEVELS:
191 return V3D_MAX_MIP_LEVELS;
192 case PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS:
193 return 2048;
194
195 /* Render targets. */
196 case PIPE_CAP_MAX_RENDER_TARGETS:
197 return 4;
198
199 case PIPE_CAP_VENDOR_ID:
200 return 0x14E4;
201 case PIPE_CAP_ACCELERATED:
202 return 1;
203 case PIPE_CAP_VIDEO_MEMORY: {
204 uint64_t system_memory;
205
206 if (!os_get_total_physical_memory(&system_memory))
207 return 0;
208
209 return (int)(system_memory >> 20);
210 }
211 case PIPE_CAP_UMA:
212 return 1;
213
214 default:
215 return u_pipe_screen_get_param_defaults(pscreen, param);
216 }
217 }
218
219 static float
220 v3d_screen_get_paramf(struct pipe_screen *pscreen, enum pipe_capf param)
221 {
222 switch (param) {
223 case PIPE_CAPF_MAX_LINE_WIDTH:
224 case PIPE_CAPF_MAX_LINE_WIDTH_AA:
225 return 32;
226
227 case PIPE_CAPF_MAX_POINT_WIDTH:
228 case PIPE_CAPF_MAX_POINT_WIDTH_AA:
229 return 512.0f;
230
231 case PIPE_CAPF_MAX_TEXTURE_ANISOTROPY:
232 return 0.0f;
233 case PIPE_CAPF_MAX_TEXTURE_LOD_BIAS:
234 return 16.0f;
235
236 case PIPE_CAPF_MIN_CONSERVATIVE_RASTER_DILATE:
237 case PIPE_CAPF_MAX_CONSERVATIVE_RASTER_DILATE:
238 case PIPE_CAPF_CONSERVATIVE_RASTER_DILATE_GRANULARITY:
239 return 0.0f;
240 default:
241 fprintf(stderr, "unknown paramf %d\n", param);
242 return 0;
243 }
244 }
245
246 static int
247 v3d_screen_get_shader_param(struct pipe_screen *pscreen, unsigned shader,
248 enum pipe_shader_cap param)
249 {
250 struct v3d_screen *screen = v3d_screen(pscreen);
251
252 if (shader != PIPE_SHADER_VERTEX &&
253 shader != PIPE_SHADER_FRAGMENT) {
254 return 0;
255 }
256
257 /* this is probably not totally correct.. but it's a start: */
258 switch (param) {
259 case PIPE_SHADER_CAP_MAX_INSTRUCTIONS:
260 case PIPE_SHADER_CAP_MAX_ALU_INSTRUCTIONS:
261 case PIPE_SHADER_CAP_MAX_TEX_INSTRUCTIONS:
262 case PIPE_SHADER_CAP_MAX_TEX_INDIRECTIONS:
263 return 16384;
264
265 case PIPE_SHADER_CAP_MAX_CONTROL_FLOW_DEPTH:
266 return UINT_MAX;
267
268 case PIPE_SHADER_CAP_MAX_INPUTS:
269 if (shader == PIPE_SHADER_FRAGMENT)
270 return V3D_MAX_FS_INPUTS / 4;
271 else
272 return V3D_MAX_VS_INPUTS / 4;
273 case PIPE_SHADER_CAP_MAX_OUTPUTS:
274 if (shader == PIPE_SHADER_FRAGMENT)
275 return 4;
276 else
277 return V3D_MAX_FS_INPUTS / 4;
278 case PIPE_SHADER_CAP_MAX_TEMPS:
279 return 256; /* GL_MAX_PROGRAM_TEMPORARIES_ARB */
280 case PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE:
281 return 16 * 1024 * sizeof(float);
282 case PIPE_SHADER_CAP_MAX_CONST_BUFFERS:
283 return 16;
284 case PIPE_SHADER_CAP_TGSI_CONT_SUPPORTED:
285 return 0;
286 case PIPE_SHADER_CAP_INDIRECT_INPUT_ADDR:
287 case PIPE_SHADER_CAP_INDIRECT_OUTPUT_ADDR:
288 case PIPE_SHADER_CAP_INDIRECT_TEMP_ADDR:
289 return 0;
290 case PIPE_SHADER_CAP_INDIRECT_CONST_ADDR:
291 return 1;
292 case PIPE_SHADER_CAP_SUBROUTINES:
293 return 0;
294 case PIPE_SHADER_CAP_INTEGERS:
295 return 1;
296 case PIPE_SHADER_CAP_FP16:
297 case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
298 case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
299 case PIPE_SHADER_CAP_TGSI_LDEXP_SUPPORTED:
300 case PIPE_SHADER_CAP_TGSI_FMA_SUPPORTED:
301 case PIPE_SHADER_CAP_TGSI_ANY_INOUT_DECL_RANGE:
302 case PIPE_SHADER_CAP_TGSI_SQRT_SUPPORTED:
303 case PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTERS:
304 case PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER_BUFFERS:
305 return 0;
306 case PIPE_SHADER_CAP_SCALAR_ISA:
307 return 1;
308 case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
309 case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
310 return V3D_MAX_TEXTURE_SAMPLERS;
311
312 case PIPE_SHADER_CAP_MAX_SHADER_BUFFERS:
313 return PIPE_MAX_SHADER_BUFFERS;
314
315 case PIPE_SHADER_CAP_MAX_SHADER_IMAGES:
316 if (screen->devinfo.ver < 41)
317 return 0;
318 else
319 return PIPE_MAX_SHADER_IMAGES;
320
321 case PIPE_SHADER_CAP_PREFERRED_IR:
322 return PIPE_SHADER_IR_NIR;
323 case PIPE_SHADER_CAP_SUPPORTED_IRS:
324 return 0;
325 case PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT:
326 return 32;
327 case PIPE_SHADER_CAP_LOWER_IF_THRESHOLD:
328 case PIPE_SHADER_CAP_TGSI_SKIP_MERGE_REGISTERS:
329 return 0;
330 default:
331 fprintf(stderr, "unknown shader param %d\n", param);
332 return 0;
333 }
334 return 0;
335 }
336
337 static boolean
338 v3d_screen_is_format_supported(struct pipe_screen *pscreen,
339 enum pipe_format format,
340 enum pipe_texture_target target,
341 unsigned sample_count,
342 unsigned storage_sample_count,
343 unsigned usage)
344 {
345 struct v3d_screen *screen = v3d_screen(pscreen);
346
347 if (MAX2(1, sample_count) != MAX2(1, storage_sample_count))
348 return false;
349
350 if (sample_count > 1 && sample_count != V3D_MAX_SAMPLES)
351 return FALSE;
352
353 if (target >= PIPE_MAX_TEXTURE_TYPES) {
354 return FALSE;
355 }
356
357 if (usage & PIPE_BIND_VERTEX_BUFFER) {
358 switch (format) {
359 case PIPE_FORMAT_R32G32B32A32_FLOAT:
360 case PIPE_FORMAT_R32G32B32_FLOAT:
361 case PIPE_FORMAT_R32G32_FLOAT:
362 case PIPE_FORMAT_R32_FLOAT:
363 case PIPE_FORMAT_R32G32B32A32_SNORM:
364 case PIPE_FORMAT_R32G32B32_SNORM:
365 case PIPE_FORMAT_R32G32_SNORM:
366 case PIPE_FORMAT_R32_SNORM:
367 case PIPE_FORMAT_R32G32B32A32_SSCALED:
368 case PIPE_FORMAT_R32G32B32_SSCALED:
369 case PIPE_FORMAT_R32G32_SSCALED:
370 case PIPE_FORMAT_R32_SSCALED:
371 case PIPE_FORMAT_R16G16B16A16_UNORM:
372 case PIPE_FORMAT_R16G16B16_UNORM:
373 case PIPE_FORMAT_R16G16_UNORM:
374 case PIPE_FORMAT_R16_UNORM:
375 case PIPE_FORMAT_R16G16B16A16_SNORM:
376 case PIPE_FORMAT_R16G16B16_SNORM:
377 case PIPE_FORMAT_R16G16_SNORM:
378 case PIPE_FORMAT_R16_SNORM:
379 case PIPE_FORMAT_R16G16B16A16_USCALED:
380 case PIPE_FORMAT_R16G16B16_USCALED:
381 case PIPE_FORMAT_R16G16_USCALED:
382 case PIPE_FORMAT_R16_USCALED:
383 case PIPE_FORMAT_R16G16B16A16_SSCALED:
384 case PIPE_FORMAT_R16G16B16_SSCALED:
385 case PIPE_FORMAT_R16G16_SSCALED:
386 case PIPE_FORMAT_R16_SSCALED:
387 case PIPE_FORMAT_R8G8B8A8_UNORM:
388 case PIPE_FORMAT_R8G8B8_UNORM:
389 case PIPE_FORMAT_R8G8_UNORM:
390 case PIPE_FORMAT_R8_UNORM:
391 case PIPE_FORMAT_R8G8B8A8_SNORM:
392 case PIPE_FORMAT_R8G8B8_SNORM:
393 case PIPE_FORMAT_R8G8_SNORM:
394 case PIPE_FORMAT_R8_SNORM:
395 case PIPE_FORMAT_R8G8B8A8_USCALED:
396 case PIPE_FORMAT_R8G8B8_USCALED:
397 case PIPE_FORMAT_R8G8_USCALED:
398 case PIPE_FORMAT_R8_USCALED:
399 case PIPE_FORMAT_R8G8B8A8_SSCALED:
400 case PIPE_FORMAT_R8G8B8_SSCALED:
401 case PIPE_FORMAT_R8G8_SSCALED:
402 case PIPE_FORMAT_R8_SSCALED:
403 case PIPE_FORMAT_R10G10B10A2_UNORM:
404 case PIPE_FORMAT_B10G10R10A2_UNORM:
405 case PIPE_FORMAT_R10G10B10A2_SNORM:
406 case PIPE_FORMAT_B10G10R10A2_SNORM:
407 case PIPE_FORMAT_R10G10B10A2_USCALED:
408 case PIPE_FORMAT_B10G10R10A2_USCALED:
409 case PIPE_FORMAT_R10G10B10A2_SSCALED:
410 case PIPE_FORMAT_B10G10R10A2_SSCALED:
411 break;
412 default:
413 return FALSE;
414 }
415 }
416
417 /* FORMAT_NONE gets allowed for ARB_framebuffer_no_attachments's probe
418 * of FRAMEBUFFER_MAX_SAMPLES
419 */
420 if ((usage & PIPE_BIND_RENDER_TARGET) &&
421 format != PIPE_FORMAT_NONE &&
422 !v3d_rt_format_supported(&screen->devinfo, format)) {
423 return FALSE;
424 }
425
426 if ((usage & PIPE_BIND_SAMPLER_VIEW) &&
427 !v3d_tex_format_supported(&screen->devinfo, format)) {
428 return FALSE;
429 }
430
431 if ((usage & PIPE_BIND_DEPTH_STENCIL) &&
432 !(format == PIPE_FORMAT_S8_UINT_Z24_UNORM ||
433 format == PIPE_FORMAT_X8Z24_UNORM ||
434 format == PIPE_FORMAT_Z16_UNORM ||
435 format == PIPE_FORMAT_Z32_FLOAT ||
436 format == PIPE_FORMAT_Z32_FLOAT_S8X24_UINT)) {
437 return FALSE;
438 }
439
440 if ((usage & PIPE_BIND_INDEX_BUFFER) &&
441 !(format == PIPE_FORMAT_I8_UINT ||
442 format == PIPE_FORMAT_I16_UINT ||
443 format == PIPE_FORMAT_I32_UINT)) {
444 return FALSE;
445 }
446
447 return TRUE;
448 }
449
450 #define PTR_TO_UINT(x) ((unsigned)((intptr_t)(x)))
451
452 static unsigned handle_hash(void *key)
453 {
454 return PTR_TO_UINT(key);
455 }
456
457 static int handle_compare(void *key1, void *key2)
458 {
459 return PTR_TO_UINT(key1) != PTR_TO_UINT(key2);
460 }
461
462 static bool
463 v3d_get_device_info(struct v3d_screen *screen)
464 {
465 struct drm_v3d_get_param ident0 = {
466 .param = DRM_V3D_PARAM_V3D_CORE0_IDENT0,
467 };
468 struct drm_v3d_get_param ident1 = {
469 .param = DRM_V3D_PARAM_V3D_CORE0_IDENT1,
470 };
471 int ret;
472
473 ret = v3d_ioctl(screen->fd, DRM_IOCTL_V3D_GET_PARAM, &ident0);
474 if (ret != 0) {
475 fprintf(stderr, "Couldn't get V3D core IDENT0: %s\n",
476 strerror(errno));
477 return false;
478 }
479 ret = v3d_ioctl(screen->fd, DRM_IOCTL_V3D_GET_PARAM, &ident1);
480 if (ret != 0) {
481 fprintf(stderr, "Couldn't get V3D core IDENT1: %s\n",
482 strerror(errno));
483 return false;
484 }
485
486 uint32_t major = (ident0.value >> 24) & 0xff;
487 uint32_t minor = (ident1.value >> 0) & 0xf;
488 screen->devinfo.ver = major * 10 + minor;
489
490 screen->devinfo.vpm_size = (ident1.value >> 28 & 0xf) * 8192;
491
492 switch (screen->devinfo.ver) {
493 case 33:
494 case 41:
495 case 42:
496 break;
497 default:
498 fprintf(stderr,
499 "V3D %d.%d not supported by this version of Mesa.\n",
500 screen->devinfo.ver / 10,
501 screen->devinfo.ver % 10);
502 return false;
503 }
504
505 return true;
506 }
507
508 static const void *
509 v3d_screen_get_compiler_options(struct pipe_screen *pscreen,
510 enum pipe_shader_ir ir, unsigned shader)
511 {
512 return &v3d_nir_options;
513 }
514
515 struct pipe_screen *
516 v3d_screen_create(int fd, struct renderonly *ro)
517 {
518 struct v3d_screen *screen = rzalloc(NULL, struct v3d_screen);
519 struct pipe_screen *pscreen;
520
521 pscreen = &screen->base;
522
523 pscreen->destroy = v3d_screen_destroy;
524 pscreen->get_param = v3d_screen_get_param;
525 pscreen->get_paramf = v3d_screen_get_paramf;
526 pscreen->get_shader_param = v3d_screen_get_shader_param;
527 pscreen->context_create = v3d_context_create;
528 pscreen->is_format_supported = v3d_screen_is_format_supported;
529
530 screen->fd = fd;
531 if (ro) {
532 screen->ro = renderonly_dup(ro);
533 if (!screen->ro) {
534 fprintf(stderr, "Failed to dup renderonly object\n");
535 ralloc_free(screen);
536 return NULL;
537 }
538 }
539 list_inithead(&screen->bo_cache.time_list);
540 (void)mtx_init(&screen->bo_handles_mutex, mtx_plain);
541 screen->bo_handles = util_hash_table_create(handle_hash, handle_compare);
542
543 #if defined(USE_V3D_SIMULATOR)
544 v3d_simulator_init(screen);
545 #endif
546
547 if (!v3d_get_device_info(screen))
548 goto fail;
549
550 slab_create_parent(&screen->transfer_pool, sizeof(struct v3d_transfer), 16);
551
552 v3d_fence_init(screen);
553
554 v3d_process_debug_variable();
555
556 v3d_resource_screen_init(pscreen);
557
558 screen->compiler = v3d_compiler_init(&screen->devinfo);
559
560 pscreen->get_name = v3d_screen_get_name;
561 pscreen->get_vendor = v3d_screen_get_vendor;
562 pscreen->get_device_vendor = v3d_screen_get_vendor;
563 pscreen->get_compiler_options = v3d_screen_get_compiler_options;
564
565 return pscreen;
566
567 fail:
568 close(fd);
569 ralloc_free(pscreen);
570 return NULL;
571 }