src/intel/vulkan/anv_device.c

   1 /*
   2  * Copyright © 2015 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  */
  23
  24 #include <assert.h>
  25 #include <stdbool.h>
  26 #include <string.h>
  27 #include <unistd.h>
  28 #include <fcntl.h>
  29
  30 #include "anv_private.h"
  31 #include "anv_timestamp.h"
  32 #include "util/strtod.h"
  33 #include "util/debug.h"
  34
  35 #include "genxml/gen7_pack.h"
  36
  37 struct anv_dispatch_table dtable;
  38
  39 static void
  40 compiler_debug_log(void *data, const char *fmt, ...)
  41 { }
  42
  43 static void
  44 compiler_perf_log(void *data, const char *fmt, ...)
  45 {
  46    va_list args;
  47    va_start(args, fmt);
  48
  49    if (unlikely(INTEL_DEBUG & DEBUG_PERF))
  50       vfprintf(stderr, fmt, args);
  51
  52    va_end(args);
  53 }
  54
  55 static VkResult
  56 anv_physical_device_init(struct anv_physical_device *device,
  57                          struct anv_instance *instance,
  58                          const char *path)
  59 {
  60    VkResult result;
  61    int fd;
  62
  63    fd = open(path, O_RDWR | O_CLOEXEC);
  64    if (fd < 0)
  65       return vk_error(VK_ERROR_INCOMPATIBLE_DRIVER);
  66
  67    device->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
  68    device->instance = instance;
  69
  70    assert(strlen(path) < ARRAY_SIZE(device->path));
  71    strncpy(device->path, path, ARRAY_SIZE(device->path));
  72
  73    device->chipset_id = anv_gem_get_param(fd, I915_PARAM_CHIPSET_ID);
  74    if (!device->chipset_id) {
  75       result = vk_error(VK_ERROR_INCOMPATIBLE_DRIVER);
  76       goto fail;
  77    }
  78
  79    device->name = gen_get_device_name(device->chipset_id);
  80    device->info = gen_get_device_info(device->chipset_id);
  81    if (!device->info) {
  82       result = vk_error(VK_ERROR_INCOMPATIBLE_DRIVER);
  83       goto fail;
  84    }
  85
  86    if (device->info->is_haswell) {
  87       fprintf(stderr, "WARNING: Haswell Vulkan support is incomplete\n");
  88    } else if (device->info->gen == 7 && !device->info->is_baytrail) {
  89       fprintf(stderr, "WARNING: Ivy Bridge Vulkan support is incomplete\n");
  90    } else if (device->info->gen == 7 && device->info->is_baytrail) {
  91       fprintf(stderr, "WARNING: Bay Trail Vulkan support is incomplete\n");
  92    } else if (device->info->gen >= 8) {
  93       /* Broadwell, Cherryview, Skylake, Broxton, Kabylake is as fully
  94        * supported as anything */
  95    } else {
  96       result = vk_errorf(VK_ERROR_INCOMPATIBLE_DRIVER,
  97                          "Vulkan not yet supported on %s", device->name);
  98       goto fail;
  99    }
 100
 101    device->cmd_parser_version = -1;
 102    if (device->info->gen == 7) {
 103       device->cmd_parser_version =
 104          anv_gem_get_param(fd, I915_PARAM_CMD_PARSER_VERSION);
 105       if (device->cmd_parser_version == -1) {
 106          result = vk_errorf(VK_ERROR_INITIALIZATION_FAILED,
 107                             "failed to get command parser version");
 108          goto fail;
 109       }
 110    }
 111
 112    if (anv_gem_get_aperture(fd, &device->aperture_size) == -1) {
 113       result = vk_errorf(VK_ERROR_INITIALIZATION_FAILED,
 114                          "failed to get aperture size: %m");
 115       goto fail;
 116    }
 117
 118    if (!anv_gem_get_param(fd, I915_PARAM_HAS_WAIT_TIMEOUT)) {
 119       result = vk_errorf(VK_ERROR_INITIALIZATION_FAILED,
 120                          "kernel missing gem wait");
 121       goto fail;
 122    }
 123
 124    if (!anv_gem_get_param(fd, I915_PARAM_HAS_EXECBUF2)) {
 125       result = vk_errorf(VK_ERROR_INITIALIZATION_FAILED,
 126                          "kernel missing execbuf2");
 127       goto fail;
 128    }
 129
 130    if (!device->info->has_llc &&
 131        anv_gem_get_param(fd, I915_PARAM_MMAP_VERSION) < 1) {
 132       result = vk_errorf(VK_ERROR_INITIALIZATION_FAILED,
 133                          "kernel missing wc mmap");
 134       goto fail;
 135    }
 136
 137    bool swizzled = anv_gem_get_bit6_swizzle(fd, I915_TILING_X);
 138
 139    close(fd);
 140
 141    brw_process_intel_debug_variable();
 142
 143    device->compiler = brw_compiler_create(NULL, device->info);
 144    if (device->compiler == NULL) {
 145       result = vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 146       goto fail;
 147    }
 148    device->compiler->shader_debug_log = compiler_debug_log;
 149    device->compiler->shader_perf_log = compiler_perf_log;
 150
 151    result = anv_init_wsi(device);
 152    if (result != VK_SUCCESS)
 153        goto fail;
 154
 155    /* XXX: Actually detect bit6 swizzling */
 156    isl_device_init(&device->isl_dev, device->info, swizzled);
 157
 158    return VK_SUCCESS;
 159
 160 fail:
 161    close(fd);
 162    return result;
 163 }
 164
 165 static void
 166 anv_physical_device_finish(struct anv_physical_device *device)
 167 {
 168    anv_finish_wsi(device);
 169    ralloc_free(device->compiler);
 170 }
 171
 172 static const VkExtensionProperties global_extensions[] = {
 173    {
 174       .extensionName = VK_KHR_SURFACE_EXTENSION_NAME,
 175       .specVersion = 25,
 176    },
 177 #ifdef VK_USE_PLATFORM_XCB_KHR
 178    {
 179       .extensionName = VK_KHR_XCB_SURFACE_EXTENSION_NAME,
 180       .specVersion = 5,
 181    },
 182 #endif
 183 #ifdef VK_USE_PLATFORM_XLIB_KHR
 184    {
 185       .extensionName = VK_KHR_XLIB_SURFACE_EXTENSION_NAME,
 186       .specVersion = 5,
 187    },
 188 #endif
 189 #ifdef VK_USE_PLATFORM_WAYLAND_KHR
 190    {
 191       .extensionName = VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME,
 192       .specVersion = 4,
 193    },
 194 #endif
 195 };
 196
 197 static const VkExtensionProperties device_extensions[] = {
 198    {
 199       .extensionName = VK_KHR_SWAPCHAIN_EXTENSION_NAME,
 200       .specVersion = 67,
 201    },
 202 };
 203
 204 static void *
 205 default_alloc_func(void *pUserData, size_t size, size_t align,
 206                    VkSystemAllocationScope allocationScope)
 207 {
 208    return malloc(size);
 209 }
 210
 211 static void *
 212 default_realloc_func(void *pUserData, void *pOriginal, size_t size,
 213                      size_t align, VkSystemAllocationScope allocationScope)
 214 {
 215    return realloc(pOriginal, size);
 216 }
 217
 218 static void
 219 default_free_func(void *pUserData, void *pMemory)
 220 {
 221    free(pMemory);
 222 }
 223
 224 static const VkAllocationCallbacks default_alloc = {
 225    .pUserData = NULL,
 226    .pfnAllocation = default_alloc_func,
 227    .pfnReallocation = default_realloc_func,
 228    .pfnFree = default_free_func,
 229 };
 230
 231 VkResult anv_CreateInstance(
 232     const VkInstanceCreateInfo*                 pCreateInfo,
 233     const VkAllocationCallbacks*                pAllocator,
 234     VkInstance*                                 pInstance)
 235 {
 236    struct anv_instance *instance;
 237
 238    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO);
 239
 240    uint32_t client_version;
 241    if (pCreateInfo->pApplicationInfo &&
 242        pCreateInfo->pApplicationInfo->apiVersion != 0) {
 243       client_version = pCreateInfo->pApplicationInfo->apiVersion;
 244    } else {
 245       client_version = VK_MAKE_VERSION(1, 0, 0);
 246    }
 247
 248    if (VK_MAKE_VERSION(1, 0, 0) > client_version ||
 249        client_version > VK_MAKE_VERSION(1, 0, 0xfff)) {
 250       return vk_errorf(VK_ERROR_INCOMPATIBLE_DRIVER,
 251                        "Client requested version %d.%d.%d",
 252                        VK_VERSION_MAJOR(client_version),
 253                        VK_VERSION_MINOR(client_version),
 254                        VK_VERSION_PATCH(client_version));
 255    }
 256
 257    for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
 258       bool found = false;
 259       for (uint32_t j = 0; j < ARRAY_SIZE(global_extensions); j++) {
 260          if (strcmp(pCreateInfo->ppEnabledExtensionNames[i],
 261                     global_extensions[j].extensionName) == 0) {
 262             found = true;
 263             break;
 264          }
 265       }
 266       if (!found)
 267          return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
 268    }
 269
 270    instance = anv_alloc2(&default_alloc, pAllocator, sizeof(*instance), 8,
 271                          VK_SYSTEM_ALLOCATION_SCOPE_INSTANCE);
 272    if (!instance)
 273       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 274
 275    instance->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
 276
 277    if (pAllocator)
 278       instance->alloc = *pAllocator;
 279    else
 280       instance->alloc = default_alloc;
 281
 282    instance->apiVersion = client_version;
 283    instance->physicalDeviceCount = -1;
 284
 285    _mesa_locale_init();
 286
 287    VG(VALGRIND_CREATE_MEMPOOL(instance, 0, false));
 288
 289    *pInstance = anv_instance_to_handle(instance);
 290
 291    return VK_SUCCESS;
 292 }
 293
 294 void anv_DestroyInstance(
 295     VkInstance                                  _instance,
 296     const VkAllocationCallbacks*                pAllocator)
 297 {
 298    ANV_FROM_HANDLE(anv_instance, instance, _instance);
 299
 300    if (instance->physicalDeviceCount > 0) {
 301       /* We support at most one physical device. */
 302       assert(instance->physicalDeviceCount == 1);
 303       anv_physical_device_finish(&instance->physicalDevice);
 304    }
 305
 306    VG(VALGRIND_DESTROY_MEMPOOL(instance));
 307
 308    _mesa_locale_fini();
 309
 310    anv_free(&instance->alloc, instance);
 311 }
 312
 313 VkResult anv_EnumeratePhysicalDevices(
 314     VkInstance                                  _instance,
 315     uint32_t*                                   pPhysicalDeviceCount,
 316     VkPhysicalDevice*                           pPhysicalDevices)
 317 {
 318    ANV_FROM_HANDLE(anv_instance, instance, _instance);
 319    VkResult result;
 320
 321    if (instance->physicalDeviceCount < 0) {
 322       char path[20];
 323       for (unsigned i = 0; i < 8; i++) {
 324          snprintf(path, sizeof(path), "/dev/dri/renderD%d", 128 + i);
 325          result = anv_physical_device_init(&instance->physicalDevice,
 326                                            instance, path);
 327          if (result == VK_SUCCESS)
 328             break;
 329       }
 330
 331       if (result == VK_ERROR_INCOMPATIBLE_DRIVER) {
 332          instance->physicalDeviceCount = 0;
 333       } else if (result == VK_SUCCESS) {
 334          instance->physicalDeviceCount = 1;
 335       } else {
 336          return result;
 337       }
 338    }
 339
 340    /* pPhysicalDeviceCount is an out parameter if pPhysicalDevices is NULL;
 341     * otherwise it's an inout parameter.
 342     *
 343     * The Vulkan spec (git aaed022) says:
 344     *
 345     *    pPhysicalDeviceCount is a pointer to an unsigned integer variable
 346     *    that is initialized with the number of devices the application is
 347     *    prepared to receive handles to. pname:pPhysicalDevices is pointer to
 348     *    an array of at least this many VkPhysicalDevice handles [...].
 349     *
 350     *    Upon success, if pPhysicalDevices is NULL, vkEnumeratePhysicalDevices
 351     *    overwrites the contents of the variable pointed to by
 352     *    pPhysicalDeviceCount with the number of physical devices in in the
 353     *    instance; otherwise, vkEnumeratePhysicalDevices overwrites
 354     *    pPhysicalDeviceCount with the number of physical handles written to
 355     *    pPhysicalDevices.
 356     */
 357    if (!pPhysicalDevices) {
 358       *pPhysicalDeviceCount = instance->physicalDeviceCount;
 359    } else if (*pPhysicalDeviceCount >= 1) {
 360       pPhysicalDevices[0] = anv_physical_device_to_handle(&instance->physicalDevice);
 361       *pPhysicalDeviceCount = 1;
 362    } else {
 363       *pPhysicalDeviceCount = 0;
 364    }
 365
 366    return VK_SUCCESS;
 367 }
 368
 369 void anv_GetPhysicalDeviceFeatures(
 370     VkPhysicalDevice                            physicalDevice,
 371     VkPhysicalDeviceFeatures*                   pFeatures)
 372 {
 373    ANV_FROM_HANDLE(anv_physical_device, pdevice, physicalDevice);
 374
 375    *pFeatures = (VkPhysicalDeviceFeatures) {
 376       .robustBufferAccess                       = true,
 377       .fullDrawIndexUint32                      = true,
 378       .imageCubeArray                           = false,
 379       .independentBlend                         = true,
 380       .geometryShader                           = true,
 381       .tessellationShader                       = false,
 382       .sampleRateShading                        = true,
 383       .dualSrcBlend                             = true,
 384       .logicOp                                  = true,
 385       .multiDrawIndirect                        = false,
 386       .drawIndirectFirstInstance                = false,
 387       .depthClamp                               = true,
 388       .depthBiasClamp                           = false,
 389       .fillModeNonSolid                         = true,
 390       .depthBounds                              = false,
 391       .wideLines                                = true,
 392       .largePoints                              = true,
 393       .alphaToOne                               = true,
 394       .multiViewport                            = true,
 395       .samplerAnisotropy                        = false, /* FINISHME */
 396       .textureCompressionETC2                   = pdevice->info->gen >= 8 ||
 397                                                   pdevice->info->is_baytrail,
 398       .textureCompressionASTC_LDR               = pdevice->info->gen >= 9, /* FINISHME CHV */
 399       .textureCompressionBC                     = true,
 400       .occlusionQueryPrecise                    = true,
 401       .pipelineStatisticsQuery                  = false,
 402       .fragmentStoresAndAtomics                 = true,
 403       .shaderTessellationAndGeometryPointSize   = true,
 404       .shaderImageGatherExtended                = false,
 405       .shaderStorageImageExtendedFormats        = false,
 406       .shaderStorageImageMultisample            = false,
 407       .shaderUniformBufferArrayDynamicIndexing  = true,
 408       .shaderSampledImageArrayDynamicIndexing   = true,
 409       .shaderStorageBufferArrayDynamicIndexing  = true,
 410       .shaderStorageImageArrayDynamicIndexing   = true,
 411       .shaderStorageImageReadWithoutFormat      = false,
 412       .shaderStorageImageWriteWithoutFormat     = true,
 413       .shaderClipDistance                       = false,
 414       .shaderCullDistance                       = false,
 415       .shaderFloat64                            = false,
 416       .shaderInt64                              = false,
 417       .shaderInt16                              = false,
 418       .alphaToOne                               = true,
 419       .variableMultisampleRate                  = false,
 420       .inheritedQueries                         = false,
 421    };
 422
 423    /* We can't do image stores in vec4 shaders */
 424    pFeatures->vertexPipelineStoresAndAtomics =
 425       pdevice->compiler->scalar_stage[MESA_SHADER_VERTEX] &&
 426       pdevice->compiler->scalar_stage[MESA_SHADER_GEOMETRY];
 427 }
 428
 429 void
 430 anv_device_get_cache_uuid(void *uuid)
 431 {
 432    memset(uuid, 0, VK_UUID_SIZE);
 433    snprintf(uuid, VK_UUID_SIZE, "anv-%s", ANV_TIMESTAMP);
 434 }
 435
 436 void anv_GetPhysicalDeviceProperties(
 437     VkPhysicalDevice                            physicalDevice,
 438     VkPhysicalDeviceProperties*                 pProperties)
 439 {
 440    ANV_FROM_HANDLE(anv_physical_device, pdevice, physicalDevice);
 441    const struct gen_device_info *devinfo = pdevice->info;
 442
 443    const float time_stamp_base = devinfo->gen >= 9 ? 83.333 : 80.0;
 444
 445    /* See assertions made when programming the buffer surface state. */
 446    const uint32_t max_raw_buffer_sz = devinfo->gen >= 7 ?
 447                                       (1ul << 30) : (1ul << 27);
 448
 449    VkSampleCountFlags sample_counts =
 450       isl_device_get_sample_counts(&pdevice->isl_dev);
 451
 452    VkPhysicalDeviceLimits limits = {
 453       .maxImageDimension1D                      = (1 << 14),
 454       .maxImageDimension2D                      = (1 << 14),
 455       .maxImageDimension3D                      = (1 << 11),
 456       .maxImageDimensionCube                    = (1 << 14),
 457       .maxImageArrayLayers                      = (1 << 11),
 458       .maxTexelBufferElements                   = 128 * 1024 * 1024,
 459       .maxUniformBufferRange                    = (1ul << 27),
 460       .maxStorageBufferRange                    = max_raw_buffer_sz,
 461       .maxPushConstantsSize                     = MAX_PUSH_CONSTANTS_SIZE,
 462       .maxMemoryAllocationCount                 = UINT32_MAX,
 463       .maxSamplerAllocationCount                = 64 * 1024,
 464       .bufferImageGranularity                   = 64, /* A cache line */
 465       .sparseAddressSpaceSize                   = 0,
 466       .maxBoundDescriptorSets                   = MAX_SETS,
 467       .maxPerStageDescriptorSamplers            = 64,
 468       .maxPerStageDescriptorUniformBuffers      = 64,
 469       .maxPerStageDescriptorStorageBuffers      = 64,
 470       .maxPerStageDescriptorSampledImages       = 64,
 471       .maxPerStageDescriptorStorageImages       = 64,
 472       .maxPerStageDescriptorInputAttachments    = 64,
 473       .maxPerStageResources                     = 128,
 474       .maxDescriptorSetSamplers                 = 256,
 475       .maxDescriptorSetUniformBuffers           = 256,
 476       .maxDescriptorSetUniformBuffersDynamic    = 256,
 477       .maxDescriptorSetStorageBuffers           = 256,
 478       .maxDescriptorSetStorageBuffersDynamic    = 256,
 479       .maxDescriptorSetSampledImages            = 256,
 480       .maxDescriptorSetStorageImages            = 256,
 481       .maxDescriptorSetInputAttachments         = 256,
 482       .maxVertexInputAttributes                 = 32,
 483       .maxVertexInputBindings                   = 32,
 484       .maxVertexInputAttributeOffset            = 2047,
 485       .maxVertexInputBindingStride              = 2048,
 486       .maxVertexOutputComponents                = 128,
 487       .maxTessellationGenerationLevel           = 0,
 488       .maxTessellationPatchSize                 = 0,
 489       .maxTessellationControlPerVertexInputComponents = 0,
 490       .maxTessellationControlPerVertexOutputComponents = 0,
 491       .maxTessellationControlPerPatchOutputComponents = 0,
 492       .maxTessellationControlTotalOutputComponents = 0,
 493       .maxTessellationEvaluationInputComponents = 0,
 494       .maxTessellationEvaluationOutputComponents = 0,
 495       .maxGeometryShaderInvocations             = 32,
 496       .maxGeometryInputComponents               = 64,
 497       .maxGeometryOutputComponents              = 128,
 498       .maxGeometryOutputVertices                = 256,
 499       .maxGeometryTotalOutputComponents         = 1024,
 500       .maxFragmentInputComponents               = 128,
 501       .maxFragmentOutputAttachments             = 8,
 502       .maxFragmentDualSrcAttachments            = 2,
 503       .maxFragmentCombinedOutputResources       = 8,
 504       .maxComputeSharedMemorySize               = 32768,
 505       .maxComputeWorkGroupCount                 = { 65535, 65535, 65535 },
 506       .maxComputeWorkGroupInvocations           = 16 * devinfo->max_cs_threads,
 507       .maxComputeWorkGroupSize = {
 508          16 * devinfo->max_cs_threads,
 509          16 * devinfo->max_cs_threads,
 510          16 * devinfo->max_cs_threads,
 511       },
 512       .subPixelPrecisionBits                    = 4 /* FIXME */,
 513       .subTexelPrecisionBits                    = 4 /* FIXME */,
 514       .mipmapPrecisionBits                      = 4 /* FIXME */,
 515       .maxDrawIndexedIndexValue                 = UINT32_MAX,
 516       .maxDrawIndirectCount                     = UINT32_MAX,
 517       .maxSamplerLodBias                        = 16,
 518       .maxSamplerAnisotropy                     = 16,
 519       .maxViewports                             = MAX_VIEWPORTS,
 520       .maxViewportDimensions                    = { (1 << 14), (1 << 14) },
 521       .viewportBoundsRange                      = { INT16_MIN, INT16_MAX },
 522       .viewportSubPixelBits                     = 13, /* We take a float? */
 523       .minMemoryMapAlignment                    = 4096, /* A page */
 524       .minTexelBufferOffsetAlignment            = 1,
 525       .minUniformBufferOffsetAlignment          = 1,
 526       .minStorageBufferOffsetAlignment          = 1,
 527       .minTexelOffset                           = -8,
 528       .maxTexelOffset                           = 7,
 529       .minTexelGatherOffset                     = -8,
 530       .maxTexelGatherOffset                     = 7,
 531       .minInterpolationOffset                   = -0.5,
 532       .maxInterpolationOffset                   = 0.4375,
 533       .subPixelInterpolationOffsetBits          = 4,
 534       .maxFramebufferWidth                      = (1 << 14),
 535       .maxFramebufferHeight                     = (1 << 14),
 536       .maxFramebufferLayers                     = (1 << 10),
 537       .framebufferColorSampleCounts             = sample_counts,
 538       .framebufferDepthSampleCounts             = sample_counts,
 539       .framebufferStencilSampleCounts           = sample_counts,
 540       .framebufferNoAttachmentsSampleCounts     = sample_counts,
 541       .maxColorAttachments                      = MAX_RTS,
 542       .sampledImageColorSampleCounts            = sample_counts,
 543       .sampledImageIntegerSampleCounts          = VK_SAMPLE_COUNT_1_BIT,
 544       .sampledImageDepthSampleCounts            = sample_counts,
 545       .sampledImageStencilSampleCounts          = sample_counts,
 546       .storageImageSampleCounts                 = VK_SAMPLE_COUNT_1_BIT,
 547       .maxSampleMaskWords                       = 1,
 548       .timestampComputeAndGraphics              = false,
 549       .timestampPeriod                          = time_stamp_base / (1000 * 1000 * 1000),
 550       .maxClipDistances                         = 0 /* FIXME */,
 551       .maxCullDistances                         = 0 /* FIXME */,
 552       .maxCombinedClipAndCullDistances          = 0 /* FIXME */,
 553       .discreteQueuePriorities                  = 1,
 554       .pointSizeRange                           = { 0.125, 255.875 },
 555       .lineWidthRange                           = { 0.0, 7.9921875 },
 556       .pointSizeGranularity                     = (1.0 / 8.0),
 557       .lineWidthGranularity                     = (1.0 / 128.0),
 558       .strictLines                              = false, /* FINISHME */
 559       .standardSampleLocations                  = true,
 560       .optimalBufferCopyOffsetAlignment         = 128,
 561       .optimalBufferCopyRowPitchAlignment       = 128,
 562       .nonCoherentAtomSize                      = 64,
 563    };
 564
 565    *pProperties = (VkPhysicalDeviceProperties) {
 566       .apiVersion = VK_MAKE_VERSION(1, 0, 5),
 567       .driverVersion = 1,
 568       .vendorID = 0x8086,
 569       .deviceID = pdevice->chipset_id,
 570       .deviceType = VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU,
 571       .limits = limits,
 572       .sparseProperties = {0}, /* Broadwell doesn't do sparse. */
 573    };
 574
 575    strcpy(pProperties->deviceName, pdevice->name);
 576    anv_device_get_cache_uuid(pProperties->pipelineCacheUUID);
 577 }
 578
 579 void anv_GetPhysicalDeviceQueueFamilyProperties(
 580     VkPhysicalDevice                            physicalDevice,
 581     uint32_t*                                   pCount,
 582     VkQueueFamilyProperties*                    pQueueFamilyProperties)
 583 {
 584    if (pQueueFamilyProperties == NULL) {
 585       *pCount = 1;
 586       return;
 587    }
 588
 589    assert(*pCount >= 1);
 590
 591    *pQueueFamilyProperties = (VkQueueFamilyProperties) {
 592       .queueFlags = VK_QUEUE_GRAPHICS_BIT |
 593                     VK_QUEUE_COMPUTE_BIT |
 594                     VK_QUEUE_TRANSFER_BIT,
 595       .queueCount = 1,
 596       .timestampValidBits = 36, /* XXX: Real value here */
 597       .minImageTransferGranularity = (VkExtent3D) { 1, 1, 1 },
 598    };
 599 }
 600
 601 void anv_GetPhysicalDeviceMemoryProperties(
 602     VkPhysicalDevice                            physicalDevice,
 603     VkPhysicalDeviceMemoryProperties*           pMemoryProperties)
 604 {
 605    ANV_FROM_HANDLE(anv_physical_device, physical_device, physicalDevice);
 606    VkDeviceSize heap_size;
 607
 608    /* Reserve some wiggle room for the driver by exposing only 75% of the
 609     * aperture to the heap.
 610     */
 611    heap_size = 3 * physical_device->aperture_size / 4;
 612
 613    if (physical_device->info->has_llc) {
 614       /* Big core GPUs share LLC with the CPU and thus one memory type can be
 615        * both cached and coherent at the same time.
 616        */
 617       pMemoryProperties->memoryTypeCount = 1;
 618       pMemoryProperties->memoryTypes[0] = (VkMemoryType) {
 619          .propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT |
 620                           VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT |
 621                           VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
 622                           VK_MEMORY_PROPERTY_HOST_CACHED_BIT,
 623          .heapIndex = 0,
 624       };
 625    } else {
 626       /* The spec requires that we expose a host-visible, coherent memory
 627        * type, but Atom GPUs don't share LLC. Thus we offer two memory types
 628        * to give the application a choice between cached, but not coherent and
 629        * coherent but uncached (WC though).
 630        */
 631       pMemoryProperties->memoryTypeCount = 2;
 632       pMemoryProperties->memoryTypes[0] = (VkMemoryType) {
 633          .propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT |
 634                           VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT |
 635                           VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
 636          .heapIndex = 0,
 637       };
 638       pMemoryProperties->memoryTypes[1] = (VkMemoryType) {
 639          .propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT |
 640                           VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT |
 641                           VK_MEMORY_PROPERTY_HOST_CACHED_BIT,
 642          .heapIndex = 0,
 643       };
 644    }
 645
 646    pMemoryProperties->memoryHeapCount = 1;
 647    pMemoryProperties->memoryHeaps[0] = (VkMemoryHeap) {
 648       .size = heap_size,
 649       .flags = VK_MEMORY_HEAP_DEVICE_LOCAL_BIT,
 650    };
 651 }
 652
 653 PFN_vkVoidFunction anv_GetInstanceProcAddr(
 654     VkInstance                                  instance,
 655     const char*                                 pName)
 656 {
 657    return anv_lookup_entrypoint(pName);
 658 }
 659
 660 /* With version 1+ of the loader interface the ICD should expose
 661  * vk_icdGetInstanceProcAddr to work around certain LD_PRELOAD issues seen in apps.
 662  */
 663 PUBLIC
 664 VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_icdGetInstanceProcAddr(
 665     VkInstance                                  instance,
 666     const char*                                 pName);
 667
 668 PUBLIC
 669 VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_icdGetInstanceProcAddr(
 670     VkInstance                                  instance,
 671     const char*                                 pName)
 672 {
 673    return anv_GetInstanceProcAddr(instance, pName);
 674 }
 675
 676 PFN_vkVoidFunction anv_GetDeviceProcAddr(
 677     VkDevice                                    device,
 678     const char*                                 pName)
 679 {
 680    return anv_lookup_entrypoint(pName);
 681 }
 682
 683 static VkResult
 684 anv_queue_init(struct anv_device *device, struct anv_queue *queue)
 685 {
 686    queue->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
 687    queue->device = device;
 688    queue->pool = &device->surface_state_pool;
 689
 690    return VK_SUCCESS;
 691 }
 692
 693 static void
 694 anv_queue_finish(struct anv_queue *queue)
 695 {
 696 }
 697
 698 static struct anv_state
 699 anv_state_pool_emit_data(struct anv_state_pool *pool, size_t size, size_t align, const void *p)
 700 {
 701    struct anv_state state;
 702
 703    state = anv_state_pool_alloc(pool, size, align);
 704    memcpy(state.map, p, size);
 705
 706    if (!pool->block_pool->device->info.has_llc)
 707       anv_state_clflush(state);
 708
 709    return state;
 710 }
 711
 712 struct gen8_border_color {
 713    union {
 714       float float32[4];
 715       uint32_t uint32[4];
 716    };
 717    /* Pad out to 64 bytes */
 718    uint32_t _pad[12];
 719 };
 720
 721 static void
 722 anv_device_init_border_colors(struct anv_device *device)
 723 {
 724    static const struct gen8_border_color border_colors[] = {
 725       [VK_BORDER_COLOR_FLOAT_TRANSPARENT_BLACK] =  { .float32 = { 0.0, 0.0, 0.0, 0.0 } },
 726       [VK_BORDER_COLOR_FLOAT_OPAQUE_BLACK] =       { .float32 = { 0.0, 0.0, 0.0, 1.0 } },
 727       [VK_BORDER_COLOR_FLOAT_OPAQUE_WHITE] =       { .float32 = { 1.0, 1.0, 1.0, 1.0 } },
 728       [VK_BORDER_COLOR_INT_TRANSPARENT_BLACK] =    { .uint32 = { 0, 0, 0, 0 } },
 729       [VK_BORDER_COLOR_INT_OPAQUE_BLACK] =         { .uint32 = { 0, 0, 0, 1 } },
 730       [VK_BORDER_COLOR_INT_OPAQUE_WHITE] =         { .uint32 = { 1, 1, 1, 1 } },
 731    };
 732
 733    device->border_colors = anv_state_pool_emit_data(&device->dynamic_state_pool,
 734                                                     sizeof(border_colors), 64,
 735                                                     border_colors);
 736 }
 737
 738 VkResult
 739 anv_device_submit_simple_batch(struct anv_device *device,
 740                                struct anv_batch *batch)
 741 {
 742    struct drm_i915_gem_execbuffer2 execbuf;
 743    struct drm_i915_gem_exec_object2 exec2_objects[1];
 744    struct anv_bo bo;
 745    VkResult result = VK_SUCCESS;
 746    uint32_t size;
 747    int64_t timeout;
 748    int ret;
 749
 750    /* Kernel driver requires 8 byte aligned batch length */
 751    size = align_u32(batch->next - batch->start, 8);
 752    result = anv_bo_pool_alloc(&device->batch_bo_pool, &bo, size);
 753    if (result != VK_SUCCESS)
 754       return result;
 755
 756    memcpy(bo.map, batch->start, size);
 757    if (!device->info.has_llc)
 758       anv_clflush_range(bo.map, size);
 759
 760    exec2_objects[0].handle = bo.gem_handle;
 761    exec2_objects[0].relocation_count = 0;
 762    exec2_objects[0].relocs_ptr = 0;
 763    exec2_objects[0].alignment = 0;
 764    exec2_objects[0].offset = bo.offset;
 765    exec2_objects[0].flags = 0;
 766    exec2_objects[0].rsvd1 = 0;
 767    exec2_objects[0].rsvd2 = 0;
 768
 769    execbuf.buffers_ptr = (uintptr_t) exec2_objects;
 770    execbuf.buffer_count = 1;
 771    execbuf.batch_start_offset = 0;
 772    execbuf.batch_len = size;
 773    execbuf.cliprects_ptr = 0;
 774    execbuf.num_cliprects = 0;
 775    execbuf.DR1 = 0;
 776    execbuf.DR4 = 0;
 777
 778    execbuf.flags =
 779       I915_EXEC_HANDLE_LUT | I915_EXEC_NO_RELOC | I915_EXEC_RENDER;
 780    execbuf.rsvd1 = device->context_id;
 781    execbuf.rsvd2 = 0;
 782
 783    ret = anv_gem_execbuffer(device, &execbuf);
 784    if (ret != 0) {
 785       /* We don't know the real error. */
 786       result = vk_errorf(VK_ERROR_OUT_OF_DEVICE_MEMORY, "execbuf2 failed: %m");
 787       goto fail;
 788    }
 789
 790    timeout = INT64_MAX;
 791    ret = anv_gem_wait(device, bo.gem_handle, &timeout);
 792    if (ret != 0) {
 793       /* We don't know the real error. */
 794       result = vk_errorf(VK_ERROR_OUT_OF_DEVICE_MEMORY, "execbuf2 failed: %m");
 795       goto fail;
 796    }
 797
 798  fail:
 799    anv_bo_pool_free(&device->batch_bo_pool, &bo);
 800
 801    return result;
 802 }
 803
 804 VkResult anv_CreateDevice(
 805     VkPhysicalDevice                            physicalDevice,
 806     const VkDeviceCreateInfo*                   pCreateInfo,
 807     const VkAllocationCallbacks*                pAllocator,
 808     VkDevice*                                   pDevice)
 809 {
 810    ANV_FROM_HANDLE(anv_physical_device, physical_device, physicalDevice);
 811    VkResult result;
 812    struct anv_device *device;
 813
 814    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO);
 815
 816    for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {
 817       bool found = false;
 818       for (uint32_t j = 0; j < ARRAY_SIZE(device_extensions); j++) {
 819          if (strcmp(pCreateInfo->ppEnabledExtensionNames[i],
 820                     device_extensions[j].extensionName) == 0) {
 821             found = true;
 822             break;
 823          }
 824       }
 825       if (!found)
 826          return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);
 827    }
 828
 829    anv_set_dispatch_devinfo(physical_device->info);
 830
 831    device = anv_alloc2(&physical_device->instance->alloc, pAllocator,
 832                        sizeof(*device), 8,
 833                        VK_SYSTEM_ALLOCATION_SCOPE_DEVICE);
 834    if (!device)
 835       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
 836
 837    device->_loader_data.loaderMagic = ICD_LOADER_MAGIC;
 838    device->instance = physical_device->instance;
 839    device->chipset_id = physical_device->chipset_id;
 840
 841    if (pAllocator)
 842       device->alloc = *pAllocator;
 843    else
 844       device->alloc = physical_device->instance->alloc;
 845
 846    /* XXX(chadv): Can we dup() physicalDevice->fd here? */
 847    device->fd = open(physical_device->path, O_RDWR | O_CLOEXEC);
 848    if (device->fd == -1) {
 849       result = vk_error(VK_ERROR_INITIALIZATION_FAILED);
 850       goto fail_device;
 851    }
 852
 853    device->context_id = anv_gem_create_context(device);
 854    if (device->context_id == -1) {
 855       result = vk_error(VK_ERROR_INITIALIZATION_FAILED);
 856       goto fail_fd;
 857    }
 858
 859    device->info = *physical_device->info;
 860    device->isl_dev = physical_device->isl_dev;
 861
 862    /* On Broadwell and later, we can use batch chaining to more efficiently
 863     * implement growing command buffers.  Prior to Haswell, the kernel
 864     * command parser gets in the way and we have to fall back to growing
 865     * the batch.
 866     */
 867    device->can_chain_batches = device->info.gen >= 8;
 868
 869    device->robust_buffer_access = pCreateInfo->pEnabledFeatures &&
 870       pCreateInfo->pEnabledFeatures->robustBufferAccess;
 871
 872    pthread_mutex_init(&device->mutex, NULL);
 873
 874    anv_bo_pool_init(&device->batch_bo_pool, device);
 875
 876    anv_block_pool_init(&device->dynamic_state_block_pool, device, 16384);
 877
 878    anv_state_pool_init(&device->dynamic_state_pool,
 879                        &device->dynamic_state_block_pool);
 880
 881    anv_block_pool_init(&device->instruction_block_pool, device, 128 * 1024);
 882    anv_state_pool_init(&device->instruction_state_pool,
 883                        &device->instruction_block_pool);
 884
 885    anv_block_pool_init(&device->surface_state_block_pool, device, 4096);
 886
 887    anv_state_pool_init(&device->surface_state_pool,
 888                        &device->surface_state_block_pool);
 889
 890    anv_bo_init_new(&device->workaround_bo, device, 1024);
 891
 892    anv_scratch_pool_init(device, &device->scratch_pool);
 893
 894    anv_queue_init(device, &device->queue);
 895
 896    switch (device->info.gen) {
 897    case 7:
 898       if (!device->info.is_haswell)
 899          result = gen7_init_device_state(device);
 900       else
 901          result = gen75_init_device_state(device);
 902       break;
 903    case 8:
 904       result = gen8_init_device_state(device);
 905       break;
 906    case 9:
 907       result = gen9_init_device_state(device);
 908       break;
 909    default:
 910       /* Shouldn't get here as we don't create physical devices for any other
 911        * gens. */
 912       unreachable("unhandled gen");
 913    }
 914    if (result != VK_SUCCESS)
 915       goto fail_fd;
 916
 917    result = anv_device_init_meta(device);
 918    if (result != VK_SUCCESS)
 919       goto fail_fd;
 920
 921    anv_device_init_border_colors(device);
 922
 923    *pDevice = anv_device_to_handle(device);
 924
 925    return VK_SUCCESS;
 926
 927  fail_fd:
 928    close(device->fd);
 929  fail_device:
 930    anv_free(&device->alloc, device);
 931
 932    return result;
 933 }
 934
 935 void anv_DestroyDevice(
 936     VkDevice                                    _device,
 937     const VkAllocationCallbacks*                pAllocator)
 938 {
 939    ANV_FROM_HANDLE(anv_device, device, _device);
 940
 941    anv_queue_finish(&device->queue);
 942
 943    anv_device_finish_meta(device);
 944
 945 #ifdef HAVE_VALGRIND
 946    /* We only need to free these to prevent valgrind errors.  The backing
 947     * BO will go away in a couple of lines so we don't actually leak.
 948     */
 949    anv_state_pool_free(&device->dynamic_state_pool, device->border_colors);
 950 #endif
 951
 952    anv_gem_munmap(device->workaround_bo.map, device->workaround_bo.size);
 953    anv_gem_close(device, device->workaround_bo.gem_handle);
 954
 955    anv_bo_pool_finish(&device->batch_bo_pool);
 956    anv_state_pool_finish(&device->dynamic_state_pool);
 957    anv_block_pool_finish(&device->dynamic_state_block_pool);
 958    anv_state_pool_finish(&device->instruction_state_pool);
 959    anv_block_pool_finish(&device->instruction_block_pool);
 960    anv_state_pool_finish(&device->surface_state_pool);
 961    anv_block_pool_finish(&device->surface_state_block_pool);
 962    anv_scratch_pool_finish(device, &device->scratch_pool);
 963
 964    close(device->fd);
 965
 966    pthread_mutex_destroy(&device->mutex);
 967
 968    anv_free(&device->alloc, device);
 969 }
 970
 971 VkResult anv_EnumerateInstanceExtensionProperties(
 972     const char*                                 pLayerName,
 973     uint32_t*                                   pPropertyCount,
 974     VkExtensionProperties*                      pProperties)
 975 {
 976    if (pProperties == NULL) {
 977       *pPropertyCount = ARRAY_SIZE(global_extensions);
 978       return VK_SUCCESS;
 979    }
 980
 981    assert(*pPropertyCount >= ARRAY_SIZE(global_extensions));
 982
 983    *pPropertyCount = ARRAY_SIZE(global_extensions);
 984    memcpy(pProperties, global_extensions, sizeof(global_extensions));
 985
 986    return VK_SUCCESS;
 987 }
 988
 989 VkResult anv_EnumerateDeviceExtensionProperties(
 990     VkPhysicalDevice                            physicalDevice,
 991     const char*                                 pLayerName,
 992     uint32_t*                                   pPropertyCount,
 993     VkExtensionProperties*                      pProperties)
 994 {
 995    if (pProperties == NULL) {
 996       *pPropertyCount = ARRAY_SIZE(device_extensions);
 997       return VK_SUCCESS;
 998    }
 999
1000    assert(*pPropertyCount >= ARRAY_SIZE(device_extensions));
1001
1002    *pPropertyCount = ARRAY_SIZE(device_extensions);
1003    memcpy(pProperties, device_extensions, sizeof(device_extensions));
1004
1005    return VK_SUCCESS;
1006 }
1007
1008 VkResult anv_EnumerateInstanceLayerProperties(
1009     uint32_t*                                   pPropertyCount,
1010     VkLayerProperties*                          pProperties)
1011 {
1012    if (pProperties == NULL) {
1013       *pPropertyCount = 0;
1014       return VK_SUCCESS;
1015    }
1016
1017    /* None supported at this time */
1018    return vk_error(VK_ERROR_LAYER_NOT_PRESENT);
1019 }
1020
1021 VkResult anv_EnumerateDeviceLayerProperties(
1022     VkPhysicalDevice                            physicalDevice,
1023     uint32_t*                                   pPropertyCount,
1024     VkLayerProperties*                          pProperties)
1025 {
1026    if (pProperties == NULL) {
1027       *pPropertyCount = 0;
1028       return VK_SUCCESS;
1029    }
1030
1031    /* None supported at this time */
1032    return vk_error(VK_ERROR_LAYER_NOT_PRESENT);
1033 }
1034
1035 void anv_GetDeviceQueue(
1036     VkDevice                                    _device,
1037     uint32_t                                    queueNodeIndex,
1038     uint32_t                                    queueIndex,
1039     VkQueue*                                    pQueue)
1040 {
1041    ANV_FROM_HANDLE(anv_device, device, _device);
1042
1043    assert(queueIndex == 0);
1044
1045    *pQueue = anv_queue_to_handle(&device->queue);
1046 }
1047
1048 VkResult anv_QueueSubmit(
1049     VkQueue                                     _queue,
1050     uint32_t                                    submitCount,
1051     const VkSubmitInfo*                         pSubmits,
1052     VkFence                                     _fence)
1053 {
1054    ANV_FROM_HANDLE(anv_queue, queue, _queue);
1055    ANV_FROM_HANDLE(anv_fence, fence, _fence);
1056    struct anv_device *device = queue->device;
1057    int ret;
1058
1059    for (uint32_t i = 0; i < submitCount; i++) {
1060       for (uint32_t j = 0; j < pSubmits[i].commandBufferCount; j++) {
1061          ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer,
1062                          pSubmits[i].pCommandBuffers[j]);
1063          assert(cmd_buffer->level == VK_COMMAND_BUFFER_LEVEL_PRIMARY);
1064
1065          ret = anv_gem_execbuffer(device, &cmd_buffer->execbuf2.execbuf);
1066          if (ret != 0) {
1067             /* We don't know the real error. */
1068             return vk_errorf(VK_ERROR_OUT_OF_DEVICE_MEMORY,
1069                              "execbuf2 failed: %m");
1070          }
1071
1072          for (uint32_t k = 0; k < cmd_buffer->execbuf2.bo_count; k++)
1073             cmd_buffer->execbuf2.bos[k]->offset = cmd_buffer->execbuf2.objects[k].offset;
1074       }
1075    }
1076
1077    if (fence) {
1078       ret = anv_gem_execbuffer(device, &fence->execbuf);
1079       if (ret != 0) {
1080          /* We don't know the real error. */
1081          return vk_errorf(VK_ERROR_OUT_OF_DEVICE_MEMORY,
1082                           "execbuf2 failed: %m");
1083       }
1084    }
1085
1086    return VK_SUCCESS;
1087 }
1088
1089 VkResult anv_QueueWaitIdle(
1090     VkQueue                                     _queue)
1091 {
1092    ANV_FROM_HANDLE(anv_queue, queue, _queue);
1093
1094    return ANV_CALL(DeviceWaitIdle)(anv_device_to_handle(queue->device));
1095 }
1096
1097 VkResult anv_DeviceWaitIdle(
1098     VkDevice                                    _device)
1099 {
1100    ANV_FROM_HANDLE(anv_device, device, _device);
1101    struct anv_batch batch;
1102
1103    uint32_t cmds[8];
1104    batch.start = batch.next = cmds;
1105    batch.end = (void *) cmds + sizeof(cmds);
1106
1107    anv_batch_emit(&batch, GEN7_MI_BATCH_BUFFER_END, bbe);
1108    anv_batch_emit(&batch, GEN7_MI_NOOP, noop);
1109
1110    return anv_device_submit_simple_batch(device, &batch);
1111 }
1112
1113 VkResult
1114 anv_bo_init_new(struct anv_bo *bo, struct anv_device *device, uint64_t size)
1115 {
1116    bo->gem_handle = anv_gem_create(device, size);
1117    if (!bo->gem_handle)
1118       return vk_error(VK_ERROR_OUT_OF_DEVICE_MEMORY);
1119
1120    bo->map = NULL;
1121    bo->index = 0;
1122    bo->offset = 0;
1123    bo->size = size;
1124    bo->is_winsys_bo = false;
1125
1126    return VK_SUCCESS;
1127 }
1128
1129 VkResult anv_AllocateMemory(
1130     VkDevice                                    _device,
1131     const VkMemoryAllocateInfo*                 pAllocateInfo,
1132     const VkAllocationCallbacks*                pAllocator,
1133     VkDeviceMemory*                             pMem)
1134 {
1135    ANV_FROM_HANDLE(anv_device, device, _device);
1136    struct anv_device_memory *mem;
1137    VkResult result;
1138
1139    assert(pAllocateInfo->sType == VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO);
1140
1141    if (pAllocateInfo->allocationSize == 0) {
1142       /* Apparently, this is allowed */
1143       *pMem = VK_NULL_HANDLE;
1144       return VK_SUCCESS;
1145    }
1146
1147    /* We support exactly one memory heap. */
1148    assert(pAllocateInfo->memoryTypeIndex == 0 ||
1149           (!device->info.has_llc && pAllocateInfo->memoryTypeIndex < 2));
1150
1151    /* FINISHME: Fail if allocation request exceeds heap size. */
1152
1153    mem = anv_alloc2(&device->alloc, pAllocator, sizeof(*mem), 8,
1154                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
1155    if (mem == NULL)
1156       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
1157
1158    /* The kernel is going to give us whole pages anyway */
1159    uint64_t alloc_size = align_u64(pAllocateInfo->allocationSize, 4096);
1160
1161    result = anv_bo_init_new(&mem->bo, device, alloc_size);
1162    if (result != VK_SUCCESS)
1163       goto fail;
1164
1165    mem->type_index = pAllocateInfo->memoryTypeIndex;
1166
1167    *pMem = anv_device_memory_to_handle(mem);
1168
1169    return VK_SUCCESS;
1170
1171  fail:
1172    anv_free2(&device->alloc, pAllocator, mem);
1173
1174    return result;
1175 }
1176
1177 void anv_FreeMemory(
1178     VkDevice                                    _device,
1179     VkDeviceMemory                              _mem,
1180     const VkAllocationCallbacks*                pAllocator)
1181 {
1182    ANV_FROM_HANDLE(anv_device, device, _device);
1183    ANV_FROM_HANDLE(anv_device_memory, mem, _mem);
1184
1185    if (mem == NULL)
1186       return;
1187
1188    if (mem->bo.map)
1189       anv_gem_munmap(mem->bo.map, mem->bo.size);
1190
1191    if (mem->bo.gem_handle != 0)
1192       anv_gem_close(device, mem->bo.gem_handle);
1193
1194    anv_free2(&device->alloc, pAllocator, mem);
1195 }
1196
1197 VkResult anv_MapMemory(
1198     VkDevice                                    _device,
1199     VkDeviceMemory                              _memory,
1200     VkDeviceSize                                offset,
1201     VkDeviceSize                                size,
1202     VkMemoryMapFlags                            flags,
1203     void**                                      ppData)
1204 {
1205    ANV_FROM_HANDLE(anv_device, device, _device);
1206    ANV_FROM_HANDLE(anv_device_memory, mem, _memory);
1207
1208    if (mem == NULL) {
1209       *ppData = NULL;
1210       return VK_SUCCESS;
1211    }
1212
1213    if (size == VK_WHOLE_SIZE)
1214       size = mem->bo.size - offset;
1215
1216    /* FIXME: Is this supposed to be thread safe? Since vkUnmapMemory() only
1217     * takes a VkDeviceMemory pointer, it seems like only one map of the memory
1218     * at a time is valid. We could just mmap up front and return an offset
1219     * pointer here, but that may exhaust virtual memory on 32 bit
1220     * userspace. */
1221
1222    uint32_t gem_flags = 0;
1223    if (!device->info.has_llc && mem->type_index == 0)
1224       gem_flags |= I915_MMAP_WC;
1225
1226    /* GEM will fail to map if the offset isn't 4k-aligned.  Round down. */
1227    uint64_t map_offset = offset & ~4095ull;
1228    assert(offset >= map_offset);
1229    uint64_t map_size = (offset + size) - map_offset;
1230
1231    /* Let's map whole pages */
1232    map_size = align_u64(map_size, 4096);
1233
1234    mem->map = anv_gem_mmap(device, mem->bo.gem_handle,
1235                            map_offset, map_size, gem_flags);
1236    mem->map_size = map_size;
1237
1238    *ppData = mem->map + (offset - map_offset);
1239
1240    return VK_SUCCESS;
1241 }
1242
1243 void anv_UnmapMemory(
1244     VkDevice                                    _device,
1245     VkDeviceMemory                              _memory)
1246 {
1247    ANV_FROM_HANDLE(anv_device_memory, mem, _memory);
1248
1249    if (mem == NULL)
1250       return;
1251
1252    anv_gem_munmap(mem->map, mem->map_size);
1253 }
1254
1255 static void
1256 clflush_mapped_ranges(struct anv_device         *device,
1257                       uint32_t                   count,
1258                       const VkMappedMemoryRange *ranges)
1259 {
1260    for (uint32_t i = 0; i < count; i++) {
1261       ANV_FROM_HANDLE(anv_device_memory, mem, ranges[i].memory);
1262       void *p = mem->map + (ranges[i].offset & ~CACHELINE_MASK);
1263       void *end;
1264
1265       if (ranges[i].offset + ranges[i].size > mem->map_size)
1266          end = mem->map + mem->map_size;
1267       else
1268          end = mem->map + ranges[i].offset + ranges[i].size;
1269
1270       while (p < end) {
1271          __builtin_ia32_clflush(p);
1272          p += CACHELINE_SIZE;
1273       }
1274    }
1275 }
1276
1277 VkResult anv_FlushMappedMemoryRanges(
1278     VkDevice                                    _device,
1279     uint32_t                                    memoryRangeCount,
1280     const VkMappedMemoryRange*                  pMemoryRanges)
1281 {
1282    ANV_FROM_HANDLE(anv_device, device, _device);
1283
1284    if (device->info.has_llc)
1285       return VK_SUCCESS;
1286
1287    /* Make sure the writes we're flushing have landed. */
1288    __builtin_ia32_mfence();
1289
1290    clflush_mapped_ranges(device, memoryRangeCount, pMemoryRanges);
1291
1292    return VK_SUCCESS;
1293 }
1294
1295 VkResult anv_InvalidateMappedMemoryRanges(
1296     VkDevice                                    _device,
1297     uint32_t                                    memoryRangeCount,
1298     const VkMappedMemoryRange*                  pMemoryRanges)
1299 {
1300    ANV_FROM_HANDLE(anv_device, device, _device);
1301
1302    if (device->info.has_llc)
1303       return VK_SUCCESS;
1304
1305    clflush_mapped_ranges(device, memoryRangeCount, pMemoryRanges);
1306
1307    /* Make sure no reads get moved up above the invalidate. */
1308    __builtin_ia32_mfence();
1309
1310    return VK_SUCCESS;
1311 }
1312
1313 void anv_GetBufferMemoryRequirements(
1314     VkDevice                                    device,
1315     VkBuffer                                    _buffer,
1316     VkMemoryRequirements*                       pMemoryRequirements)
1317 {
1318    ANV_FROM_HANDLE(anv_buffer, buffer, _buffer);
1319
1320    /* The Vulkan spec (git aaed022) says:
1321     *
1322     *    memoryTypeBits is a bitfield and contains one bit set for every
1323     *    supported memory type for the resource. The bit `1<<i` is set if and
1324     *    only if the memory type `i` in the VkPhysicalDeviceMemoryProperties
1325     *    structure for the physical device is supported.
1326     *
1327     * We support exactly one memory type.
1328     */
1329    pMemoryRequirements->memoryTypeBits = 1;
1330
1331    pMemoryRequirements->size = buffer->size;
1332    pMemoryRequirements->alignment = 16;
1333 }
1334
1335 void anv_GetImageMemoryRequirements(
1336     VkDevice                                    device,
1337     VkImage                                     _image,
1338     VkMemoryRequirements*                       pMemoryRequirements)
1339 {
1340    ANV_FROM_HANDLE(anv_image, image, _image);
1341
1342    /* The Vulkan spec (git aaed022) says:
1343     *
1344     *    memoryTypeBits is a bitfield and contains one bit set for every
1345     *    supported memory type for the resource. The bit `1<<i` is set if and
1346     *    only if the memory type `i` in the VkPhysicalDeviceMemoryProperties
1347     *    structure for the physical device is supported.
1348     *
1349     * We support exactly one memory type.
1350     */
1351    pMemoryRequirements->memoryTypeBits = 1;
1352
1353    pMemoryRequirements->size = image->size;
1354    pMemoryRequirements->alignment = image->alignment;
1355 }
1356
1357 void anv_GetImageSparseMemoryRequirements(
1358     VkDevice                                    device,
1359     VkImage                                     image,
1360     uint32_t*                                   pSparseMemoryRequirementCount,
1361     VkSparseImageMemoryRequirements*            pSparseMemoryRequirements)
1362 {
1363    stub();
1364 }
1365
1366 void anv_GetDeviceMemoryCommitment(
1367     VkDevice                                    device,
1368     VkDeviceMemory                              memory,
1369     VkDeviceSize*                               pCommittedMemoryInBytes)
1370 {
1371    *pCommittedMemoryInBytes = 0;
1372 }
1373
1374 VkResult anv_BindBufferMemory(
1375     VkDevice                                    device,
1376     VkBuffer                                    _buffer,
1377     VkDeviceMemory                              _memory,
1378     VkDeviceSize                                memoryOffset)
1379 {
1380    ANV_FROM_HANDLE(anv_device_memory, mem, _memory);
1381    ANV_FROM_HANDLE(anv_buffer, buffer, _buffer);
1382
1383    if (mem) {
1384       buffer->bo = &mem->bo;
1385       buffer->offset = memoryOffset;
1386    } else {
1387       buffer->bo = NULL;
1388       buffer->offset = 0;
1389    }
1390
1391    return VK_SUCCESS;
1392 }
1393
1394 VkResult anv_BindImageMemory(
1395     VkDevice                                    device,
1396     VkImage                                     _image,
1397     VkDeviceMemory                              _memory,
1398     VkDeviceSize                                memoryOffset)
1399 {
1400    ANV_FROM_HANDLE(anv_device_memory, mem, _memory);
1401    ANV_FROM_HANDLE(anv_image, image, _image);
1402
1403    if (mem) {
1404       image->bo = &mem->bo;
1405       image->offset = memoryOffset;
1406    } else {
1407       image->bo = NULL;
1408       image->offset = 0;
1409    }
1410
1411    return VK_SUCCESS;
1412 }
1413
1414 VkResult anv_QueueBindSparse(
1415     VkQueue                                     queue,
1416     uint32_t                                    bindInfoCount,
1417     const VkBindSparseInfo*                     pBindInfo,
1418     VkFence                                     fence)
1419 {
1420    stub_return(VK_ERROR_INCOMPATIBLE_DRIVER);
1421 }
1422
1423 VkResult anv_CreateFence(
1424     VkDevice                                    _device,
1425     const VkFenceCreateInfo*                    pCreateInfo,
1426     const VkAllocationCallbacks*                pAllocator,
1427     VkFence*                                    pFence)
1428 {
1429    ANV_FROM_HANDLE(anv_device, device, _device);
1430    struct anv_bo fence_bo;
1431    struct anv_fence *fence;
1432    struct anv_batch batch;
1433    VkResult result;
1434
1435    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_FENCE_CREATE_INFO);
1436
1437    result = anv_bo_pool_alloc(&device->batch_bo_pool, &fence_bo, 4096);
1438    if (result != VK_SUCCESS)
1439       return result;
1440
1441    /* Fences are small.  Just store the CPU data structure in the BO. */
1442    fence = fence_bo.map;
1443    fence->bo = fence_bo;
1444
1445    /* Place the batch after the CPU data but on its own cache line. */
1446    const uint32_t batch_offset = align_u32(sizeof(*fence), CACHELINE_SIZE);
1447    batch.next = batch.start = fence->bo.map + batch_offset;
1448    batch.end = fence->bo.map + fence->bo.size;
1449    anv_batch_emit(&batch, GEN7_MI_BATCH_BUFFER_END, bbe);
1450    anv_batch_emit(&batch, GEN7_MI_NOOP, noop);
1451
1452    if (!device->info.has_llc) {
1453       assert(((uintptr_t) batch.start & CACHELINE_MASK) == 0);
1454       assert(batch.next - batch.start <= CACHELINE_SIZE);
1455       __builtin_ia32_mfence();
1456       __builtin_ia32_clflush(batch.start);
1457    }
1458
1459    fence->exec2_objects[0].handle = fence->bo.gem_handle;
1460    fence->exec2_objects[0].relocation_count = 0;
1461    fence->exec2_objects[0].relocs_ptr = 0;
1462    fence->exec2_objects[0].alignment = 0;
1463    fence->exec2_objects[0].offset = fence->bo.offset;
1464    fence->exec2_objects[0].flags = 0;
1465    fence->exec2_objects[0].rsvd1 = 0;
1466    fence->exec2_objects[0].rsvd2 = 0;
1467
1468    fence->execbuf.buffers_ptr = (uintptr_t) fence->exec2_objects;
1469    fence->execbuf.buffer_count = 1;
1470    fence->execbuf.batch_start_offset = batch.start - fence->bo.map;
1471    fence->execbuf.batch_len = batch.next - batch.start;
1472    fence->execbuf.cliprects_ptr = 0;
1473    fence->execbuf.num_cliprects = 0;
1474    fence->execbuf.DR1 = 0;
1475    fence->execbuf.DR4 = 0;
1476
1477    fence->execbuf.flags =
1478       I915_EXEC_HANDLE_LUT | I915_EXEC_NO_RELOC | I915_EXEC_RENDER;
1479    fence->execbuf.rsvd1 = device->context_id;
1480    fence->execbuf.rsvd2 = 0;
1481
1482    fence->ready = false;
1483
1484    *pFence = anv_fence_to_handle(fence);
1485
1486    return VK_SUCCESS;
1487 }
1488
1489 void anv_DestroyFence(
1490     VkDevice                                    _device,
1491     VkFence                                     _fence,
1492     const VkAllocationCallbacks*                pAllocator)
1493 {
1494    ANV_FROM_HANDLE(anv_device, device, _device);
1495    ANV_FROM_HANDLE(anv_fence, fence, _fence);
1496
1497    assert(fence->bo.map == fence);
1498    anv_bo_pool_free(&device->batch_bo_pool, &fence->bo);
1499 }
1500
1501 VkResult anv_ResetFences(
1502     VkDevice                                    _device,
1503     uint32_t                                    fenceCount,
1504     const VkFence*                              pFences)
1505 {
1506    for (uint32_t i = 0; i < fenceCount; i++) {
1507       ANV_FROM_HANDLE(anv_fence, fence, pFences[i]);
1508       fence->ready = false;
1509    }
1510
1511    return VK_SUCCESS;
1512 }
1513
1514 VkResult anv_GetFenceStatus(
1515     VkDevice                                    _device,
1516     VkFence                                     _fence)
1517 {
1518    ANV_FROM_HANDLE(anv_device, device, _device);
1519    ANV_FROM_HANDLE(anv_fence, fence, _fence);
1520    int64_t t = 0;
1521    int ret;
1522
1523    if (fence->ready)
1524       return VK_SUCCESS;
1525
1526    ret = anv_gem_wait(device, fence->bo.gem_handle, &t);
1527    if (ret == 0) {
1528       fence->ready = true;
1529       return VK_SUCCESS;
1530    }
1531
1532    return VK_NOT_READY;
1533 }
1534
1535 VkResult anv_WaitForFences(
1536     VkDevice                                    _device,
1537     uint32_t                                    fenceCount,
1538     const VkFence*                              pFences,
1539     VkBool32                                    waitAll,
1540     uint64_t                                    timeout)
1541 {
1542    ANV_FROM_HANDLE(anv_device, device, _device);
1543
1544    /* DRM_IOCTL_I915_GEM_WAIT uses a signed 64 bit timeout and is supposed
1545     * to block indefinitely timeouts <= 0.  Unfortunately, this was broken
1546     * for a couple of kernel releases.  Since there's no way to know
1547     * whether or not the kernel we're using is one of the broken ones, the
1548     * best we can do is to clamp the timeout to INT64_MAX.  This limits the
1549     * maximum timeout from 584 years to 292 years - likely not a big deal.
1550     */
1551    if (timeout > INT64_MAX)
1552       timeout = INT64_MAX;
1553
1554    int64_t t = timeout;
1555
1556    /* FIXME: handle !waitAll */
1557
1558    for (uint32_t i = 0; i < fenceCount; i++) {
1559       ANV_FROM_HANDLE(anv_fence, fence, pFences[i]);
1560       int ret = anv_gem_wait(device, fence->bo.gem_handle, &t);
1561       if (ret == -1 && errno == ETIME) {
1562          return VK_TIMEOUT;
1563       } else if (ret == -1) {
1564          /* We don't know the real error. */
1565          return vk_errorf(VK_ERROR_OUT_OF_DEVICE_MEMORY,
1566                           "gem wait failed: %m");
1567       }
1568    }
1569
1570    return VK_SUCCESS;
1571 }
1572
1573 // Queue semaphore functions
1574
1575 VkResult anv_CreateSemaphore(
1576     VkDevice                                    device,
1577     const VkSemaphoreCreateInfo*                pCreateInfo,
1578     const VkAllocationCallbacks*                pAllocator,
1579     VkSemaphore*                                pSemaphore)
1580 {
1581    /* The DRM execbuffer ioctl always execute in-oder, even between different
1582     * rings. As such, there's nothing to do for the user space semaphore.
1583     */
1584
1585    *pSemaphore = (VkSemaphore)1;
1586
1587    return VK_SUCCESS;
1588 }
1589
1590 void anv_DestroySemaphore(
1591     VkDevice                                    device,
1592     VkSemaphore                                 semaphore,
1593     const VkAllocationCallbacks*                pAllocator)
1594 {
1595 }
1596
1597 // Event functions
1598
1599 VkResult anv_CreateEvent(
1600     VkDevice                                    _device,
1601     const VkEventCreateInfo*                    pCreateInfo,
1602     const VkAllocationCallbacks*                pAllocator,
1603     VkEvent*                                    pEvent)
1604 {
1605    ANV_FROM_HANDLE(anv_device, device, _device);
1606    struct anv_state state;
1607    struct anv_event *event;
1608
1609    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_EVENT_CREATE_INFO);
1610
1611    state = anv_state_pool_alloc(&device->dynamic_state_pool,
1612                                 sizeof(*event), 8);
1613    event = state.map;
1614    event->state = state;
1615    event->semaphore = VK_EVENT_RESET;
1616
1617    if (!device->info.has_llc) {
1618       /* Make sure the writes we're flushing have landed. */
1619       __builtin_ia32_mfence();
1620       __builtin_ia32_clflush(event);
1621    }
1622
1623    *pEvent = anv_event_to_handle(event);
1624
1625    return VK_SUCCESS;
1626 }
1627
1628 void anv_DestroyEvent(
1629     VkDevice                                    _device,
1630     VkEvent                                     _event,
1631     const VkAllocationCallbacks*                pAllocator)
1632 {
1633    ANV_FROM_HANDLE(anv_device, device, _device);
1634    ANV_FROM_HANDLE(anv_event, event, _event);
1635
1636    anv_state_pool_free(&device->dynamic_state_pool, event->state);
1637 }
1638
1639 VkResult anv_GetEventStatus(
1640     VkDevice                                    _device,
1641     VkEvent                                     _event)
1642 {
1643    ANV_FROM_HANDLE(anv_device, device, _device);
1644    ANV_FROM_HANDLE(anv_event, event, _event);
1645
1646    if (!device->info.has_llc) {
1647       /* Invalidate read cache before reading event written by GPU. */
1648       __builtin_ia32_clflush(event);
1649       __builtin_ia32_mfence();
1650
1651    }
1652
1653    return event->semaphore;
1654 }
1655
1656 VkResult anv_SetEvent(
1657     VkDevice                                    _device,
1658     VkEvent                                     _event)
1659 {
1660    ANV_FROM_HANDLE(anv_device, device, _device);
1661    ANV_FROM_HANDLE(anv_event, event, _event);
1662
1663    event->semaphore = VK_EVENT_SET;
1664
1665    if (!device->info.has_llc) {
1666       /* Make sure the writes we're flushing have landed. */
1667       __builtin_ia32_mfence();
1668       __builtin_ia32_clflush(event);
1669    }
1670
1671    return VK_SUCCESS;
1672 }
1673
1674 VkResult anv_ResetEvent(
1675     VkDevice                                    _device,
1676     VkEvent                                     _event)
1677 {
1678    ANV_FROM_HANDLE(anv_device, device, _device);
1679    ANV_FROM_HANDLE(anv_event, event, _event);
1680
1681    event->semaphore = VK_EVENT_RESET;
1682
1683    if (!device->info.has_llc) {
1684       /* Make sure the writes we're flushing have landed. */
1685       __builtin_ia32_mfence();
1686       __builtin_ia32_clflush(event);
1687    }
1688
1689    return VK_SUCCESS;
1690 }
1691
1692 // Buffer functions
1693
1694 VkResult anv_CreateBuffer(
1695     VkDevice                                    _device,
1696     const VkBufferCreateInfo*                   pCreateInfo,
1697     const VkAllocationCallbacks*                pAllocator,
1698     VkBuffer*                                   pBuffer)
1699 {
1700    ANV_FROM_HANDLE(anv_device, device, _device);
1701    struct anv_buffer *buffer;
1702
1703    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO);
1704
1705    buffer = anv_alloc2(&device->alloc, pAllocator, sizeof(*buffer), 8,
1706                        VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
1707    if (buffer == NULL)
1708       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
1709
1710    buffer->size = pCreateInfo->size;
1711    buffer->usage = pCreateInfo->usage;
1712    buffer->bo = NULL;
1713    buffer->offset = 0;
1714
1715    *pBuffer = anv_buffer_to_handle(buffer);
1716
1717    return VK_SUCCESS;
1718 }
1719
1720 void anv_DestroyBuffer(
1721     VkDevice                                    _device,
1722     VkBuffer                                    _buffer,
1723     const VkAllocationCallbacks*                pAllocator)
1724 {
1725    ANV_FROM_HANDLE(anv_device, device, _device);
1726    ANV_FROM_HANDLE(anv_buffer, buffer, _buffer);
1727
1728    anv_free2(&device->alloc, pAllocator, buffer);
1729 }
1730
1731 void
1732 anv_fill_buffer_surface_state(struct anv_device *device, struct anv_state state,
1733                               enum isl_format format,
1734                               uint32_t offset, uint32_t range, uint32_t stride)
1735 {
1736    isl_buffer_fill_state(&device->isl_dev, state.map,
1737                          .address = offset,
1738                          .mocs = device->default_mocs,
1739                          .size = range,
1740                          .format = format,
1741                          .stride = stride);
1742
1743    if (!device->info.has_llc)
1744       anv_state_clflush(state);
1745 }
1746
1747 void anv_DestroySampler(
1748     VkDevice                                    _device,
1749     VkSampler                                   _sampler,
1750     const VkAllocationCallbacks*                pAllocator)
1751 {
1752    ANV_FROM_HANDLE(anv_device, device, _device);
1753    ANV_FROM_HANDLE(anv_sampler, sampler, _sampler);
1754
1755    anv_free2(&device->alloc, pAllocator, sampler);
1756 }
1757
1758 VkResult anv_CreateFramebuffer(
1759     VkDevice                                    _device,
1760     const VkFramebufferCreateInfo*              pCreateInfo,
1761     const VkAllocationCallbacks*                pAllocator,
1762     VkFramebuffer*                              pFramebuffer)
1763 {
1764    ANV_FROM_HANDLE(anv_device, device, _device);
1765    struct anv_framebuffer *framebuffer;
1766
1767    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO);
1768
1769    size_t size = sizeof(*framebuffer) +
1770                  sizeof(struct anv_image_view *) * pCreateInfo->attachmentCount;
1771    framebuffer = anv_alloc2(&device->alloc, pAllocator, size, 8,
1772                             VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
1773    if (framebuffer == NULL)
1774       return vk_error(VK_ERROR_OUT_OF_HOST_MEMORY);
1775
1776    framebuffer->attachment_count = pCreateInfo->attachmentCount;
1777    for (uint32_t i = 0; i < pCreateInfo->attachmentCount; i++) {
1778       VkImageView _iview = pCreateInfo->pAttachments[i];
1779       framebuffer->attachments[i] = anv_image_view_from_handle(_iview);
1780    }
1781
1782    framebuffer->width = pCreateInfo->width;
1783    framebuffer->height = pCreateInfo->height;
1784    framebuffer->layers = pCreateInfo->layers;
1785
1786    *pFramebuffer = anv_framebuffer_to_handle(framebuffer);
1787
1788    return VK_SUCCESS;
1789 }
1790
1791 void anv_DestroyFramebuffer(
1792     VkDevice                                    _device,
1793     VkFramebuffer                               _fb,
1794     const VkAllocationCallbacks*                pAllocator)
1795 {
1796    ANV_FROM_HANDLE(anv_device, device, _device);
1797    ANV_FROM_HANDLE(anv_framebuffer, fb, _fb);
1798
1799    anv_free2(&device->alloc, pAllocator, fb);
1800 }