panfrost: LogicOp fixes and non 8-bit format support
authorIcecream95 <ixn@keemail.me>
Wed, 26 Feb 2020 09:03:13 +0000 (22:03 +1300)
committerMarge Bot <eric+marge@anholt.net>
Fri, 28 Feb 2020 11:52:40 +0000 (11:52 +0000)
commit339f127f2b38438f64d6ff846c0a3e8c3dad83f3
tree9c6ad2fec0cc85f015e5ff75258f36a7ff297250
parent574b03eebfba1a4b9de1a497857f0bbdca76ef19
panfrost: LogicOp fixes and non 8-bit format support

With the previous LogicOp commit almost half of the blend modes were
broken because the surplus bits were not cleared after an inot.

v2:
 - Remove u8 "fast path" as 8-bit is not well optimised yet
 - Don't mask for 32-bit formats as that triggers an assert

Fixes: 068806c9f6b ("panfrost: LogicOp support")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3943>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3943>
src/gallium/drivers/panfrost/nir/nir_lower_blend.c
src/gallium/drivers/panfrost/nir/nir_lower_blend.h
src/gallium/drivers/panfrost/pan_blend_shaders.c