Revert "mesa: simplify _mesa_is_image_unit_valid for buffers"
authorFrancisco Jerez <currojerez@riseup.net>
Fri, 16 Mar 2018 20:43:27 +0000 (13:43 -0700)
committerFrancisco Jerez <currojerez@riseup.net>
Wed, 23 May 2018 23:21:09 +0000 (16:21 -0700)
commit5a6814780322988a7adee525899bca8a83907ab7
tree958e526b2a6e983519a3837c55209a8fce2a6245
parent699e1f5aacd1d9eed8cc1a37ec0dbd11313fbbdc
Revert "mesa: simplify _mesa_is_image_unit_valid for buffers"

This reverts commit c0ed52f6146c7e24e1275451773bd47c1eda3145.  It was
preventing the image format validation from being done on buffer
textures, which is required to ensure that the application doesn't
attempt to bind a buffer texture with an internal format incompatible
with the image unit format (e.g. of different texel size), which is
not allowed by the spec (it's not allowed for *any* texture target,
whether or not there is spec wording restricting this behavior
specifically for buffer textures) and will cause the driver to
calculate texel bounds incorrectly and potentially crash instead of
the expected behavior.

Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106465
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
src/mesa/main/shaderimage.c