mesa: Fix memory leak in _mesa_get_uniform_location.
authorVinson Lee <vlee@freedesktop.org>
Fri, 23 Mar 2012 06:59:52 +0000 (23:59 -0700)
committerVinson Lee <vlee@freedesktop.org>
Sat, 24 Mar 2012 05:52:57 +0000 (22:52 -0700)
Fixes Coverity resource leak defect.

NOTE: This is a candidate for the 8.0 branch.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: José Fonseca <jfonseca@vmware.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/main/uniform_query.cpp

index 991df7896b41fad6567a3c823a094144d30ccc09..da41ee84c9c6daa84af104ac1d7c791a8d99f87a 100644 (file)
@@ -905,8 +905,10 @@ _mesa_get_uniform_location(struct gl_context *ctx,
       name_copy[i-1] = '\0';
 
       offset = strtol(&name[i], NULL, 10);
-      if (offset < 0)
+      if (offset < 0) {
+        free(name_copy);
         return -1;
+      }
 
       array_lookup = true;
    } else {