r300g: u_upload optimisation
authorDave Airlie <airlied@redhat.com>
Sun, 18 Jul 2010 08:47:08 +0000 (18:47 +1000)
committerMarek Olšák <maraeo@gmail.com>
Sun, 18 Jul 2010 16:11:29 +0000 (18:11 +0200)
fix vb/ib uploads

src/gallium/drivers/r300/r300_flush.c
src/gallium/drivers/r300/r300_render.c
src/gallium/drivers/r300/r300_screen_buffer.c
src/gallium/drivers/r300/r300_screen_buffer.h

index 9e5bfebe24531afc6cd67d100a8f890a7d99905d..ae7b5759e78bbd9b27d8b443257561864afff133 100644 (file)
@@ -25,6 +25,7 @@
 #include "draw/draw_private.h"
 
 #include "util/u_simple_list.h"
+#include "util/u_upload_mgr.h"
 
 #include "r300_context.h"
 #include "r300_cs.h"
@@ -39,6 +40,9 @@ static void r300_flush(struct pipe_context* pipe,
     struct r300_atom *atom;
     struct r300_fence **rfence = (struct r300_fence**)fence;
 
+    u_upload_flush(r300->upload_vb);
+    u_upload_flush(r300->upload_ib);
+
     /* We probably need to flush Draw, but we may have been called from
      * within Draw. This feels kludgy, but it might be the best thing.
      *
index e29ebea4b0626209b0f7114b90cb2676b88d4fc6..bae02135da9d18550502cbd5408e552097473443 100644 (file)
@@ -497,6 +497,7 @@ static void r300_draw_range_elements(struct pipe_context* pipe,
     unsigned short_count;
     int buffer_offset = 0, index_offset = 0; /* for index bias emulation */
     boolean translate = FALSE;
+    unsigned new_offset;
 
     if (r300->skip_rendering) {
         return;
@@ -526,18 +527,17 @@ static void r300_draw_range_elements(struct pipe_context* pipe,
                                 &start, count);
 
     r300_update_derived_state(r300);
-    r300_upload_index_buffer(r300, &indexBuffer, indexSize, start, count);
+    r300_upload_index_buffer(r300, &indexBuffer, indexSize, start, count, &new_offset);
 
+    start = new_offset;
     /* 15 dwords for emit_draw_elements */
     r300_prepare_for_rendering(r300,
         PREP_FIRST_DRAW | PREP_VALIDATE_VBOS | PREP_EMIT_AOS | PREP_INDEXED,
         indexBuffer, 15, buffer_offset, indexBias, NULL);
 
-    u_upload_flush(r300->upload_vb);
-    u_upload_flush(r300->upload_ib);
     if (alt_num_verts || count <= 65535) {
         r300_emit_draw_elements(r300, indexBuffer, indexSize,
-                                 minIndex, maxIndex, mode, start, count);
+                               minIndex, maxIndex, mode, start, count);
     } else {
         do {
             short_count = MIN2(count, 65534);
index bb5d4fac0657a92a9e3447933557d3df86b5ebb2..b19b5b5cce8f11b71b8ac808dc6091d38408ac1e 100644 (file)
@@ -62,7 +62,8 @@ int r300_upload_index_buffer(struct r300_context *r300,
                             struct pipe_resource **index_buffer,
                             unsigned index_size,
                             unsigned start,
-                            unsigned count)
+                            unsigned count,
+                            unsigned *out_offset)
 {
    struct pipe_resource *upload_buffer = NULL;
    unsigned index_offset = start * index_size;
@@ -79,7 +80,10 @@ int r300_upload_index_buffer(struct r300_context *r300,
            goto done;
        }
        *index_buffer = upload_buffer;
-    }
+       *out_offset = index_offset / index_size;
+    } else
+        *out_offset = start;
+
  done:
     //    if (upload_buffer)
     // pipe_resource_reference(&upload_buffer, NULL);
index fdd5d875d9034c8c3becaba6606deeff42a12420..cafa9f96f20f957e5f8874541b6baca8b93c1708 100644 (file)
@@ -68,7 +68,7 @@ int r300_upload_index_buffer(struct r300_context *r300,
                             struct pipe_resource **index_buffer,
                             unsigned index_size,
                             unsigned start,
-                            unsigned count);
+                            unsigned count, unsigned *out_offset);
 
 struct pipe_resource *r300_buffer_create(struct pipe_screen *screen,
                                         const struct pipe_resource *templ);