radv: Optimize calling radv_save_descriptors.
authorBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Fri, 3 Nov 2017 23:14:55 +0000 (00:14 +0100)
committerBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Sat, 4 Nov 2017 19:18:17 +0000 (20:18 +0100)
uint32_t data[MAX_SETS * 2] = {}; was getting executed before
the exit and took significant amounts of time. By having the
check outside the function, we skip the execution of the clear.

Reviewed-by: Dave Airlie <airlied@redhat.com>
src/amd/vulkan/radv_cmd_buffer.c

index 4b608377fc6578c98712996e4a0c73ece819ba35..43505a3372af351943c9e32e56cb4d4992ab33e6 100644 (file)
@@ -484,9 +484,6 @@ radv_save_descriptors(struct radv_cmd_buffer *cmd_buffer)
        uint32_t data[MAX_SETS * 2] = {};
        uint64_t va;
 
-       if (!device->trace_bo)
-               return;
-
        va = radv_buffer_get_va(device->trace_bo) + 24;
 
        MAYBE_UNUSED unsigned cdw_max = radeon_check_space(device->ws,
@@ -1723,7 +1720,8 @@ radv_flush_descriptors(struct radv_cmd_buffer *cmd_buffer,
        cmd_buffer->state.descriptors_dirty = 0;
        cmd_buffer->state.push_descriptors_dirty = false;
 
-       radv_save_descriptors(cmd_buffer);
+       if (cmd_buffer->device->trace_bo)
+               radv_save_descriptors(cmd_buffer);
 
        assert(cmd_buffer->cs->cdw <= cdw_max);
 }