uitl: Add R1_UNORM to the list of noaccess (no pack/unpack) formats.
authorEric Anholt <eric@anholt.net>
Thu, 13 Aug 2020 16:05:32 +0000 (09:05 -0700)
committerMarge Bot <eric+marge@anholt.net>
Sun, 16 Aug 2020 21:25:14 +0000 (21:25 +0000)
The functions were just stubs, if you called them you would be terribly
disappointed.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6305>

src/util/format/u_format_other.c
src/util/format/u_format_other.h
src/util/format/u_format_table.py

index 4f304e001308d3eef79a51612c5d58a0fede41bd..6dd66c7d346d87eadb7150104ccb8cbf9a8ffc86 100644 (file)
@@ -237,50 +237,6 @@ util_format_r11g11b10_float_pack_rgba_8unorm(uint8_t *dst_row, unsigned dst_stri
    }
 }
 
-
-void
-util_format_r1_unorm_unpack_rgba_float(UNUSED void *dst_row, UNUSED unsigned dst_stride,
-                                  UNUSED const uint8_t *src_row, UNUSED unsigned src_stride,
-                                  UNUSED unsigned width, UNUSED unsigned height)
-{
-
-}
-
-
-void
-util_format_r1_unorm_pack_rgba_float(UNUSED uint8_t *dst_row, UNUSED unsigned dst_stride,
-                                UNUSED const float *src_row, UNUSED unsigned src_stride,
-                                UNUSED unsigned width, UNUSED unsigned height)
-{
-
-}
-
-
-void
-util_format_r1_unorm_fetch_rgba_float(UNUSED float *dst, UNUSED const uint8_t *src,
-                                 UNUSED unsigned i, UNUSED unsigned j)
-{
-
-}
-
-
-void
-util_format_r1_unorm_unpack_rgba_8unorm(UNUSED uint8_t *dst_row, UNUSED unsigned dst_stride,
-                                   UNUSED const uint8_t *src_row, UNUSED unsigned src_stride,
-                                   UNUSED unsigned width, UNUSED unsigned height)
-{
-
-}
-
-
-void
-util_format_r1_unorm_pack_rgba_8unorm(UNUSED uint8_t *dst_row, UNUSED unsigned dst_stride,
-                                 UNUSED const uint8_t *src_row, UNUSED unsigned src_stride,
-                                 UNUSED unsigned width, UNUSED unsigned height)
-{
-}
-
-
 /*
  * PIPE_FORMAT_R8G8Bx_SNORM
  *
index 8ca5d05bc8f0d89e59efb59ec87fef70e4da3e40..df9d057754f789064671382db1269c2123743fcb 100644 (file)
@@ -83,30 +83,6 @@ util_format_r11g11b10_float_pack_rgba_8unorm(uint8_t *dst_row, unsigned dst_stri
                                        unsigned width, unsigned height);
 
 
-void
-util_format_r1_unorm_unpack_rgba_float(void *dst_row, unsigned dst_stride,
-                                  const uint8_t *src_row, unsigned src_stride,
-                                  unsigned width, unsigned height);
-
-void
-util_format_r1_unorm_pack_rgba_float(uint8_t *dst_row, unsigned dst_stride,
-                                const float *src_row, unsigned src_stride,
-                                unsigned width, unsigned height);
-
-void
-util_format_r1_unorm_fetch_rgba_float(float *dst, const uint8_t *src,
-                                 unsigned i, unsigned j);
-
-void
-util_format_r1_unorm_unpack_rgba_8unorm(uint8_t *dst_row, unsigned dst_stride,
-                                   const uint8_t *src_row, unsigned src_stride,
-                                   unsigned width, unsigned height);
-
-void
-util_format_r1_unorm_pack_rgba_8unorm(uint8_t *dst_row, unsigned dst_stride,
-                                 const uint8_t *src_row, unsigned src_stride,
-                                 unsigned width, unsigned height);
-
 void
 util_format_r8g8bx_snorm_unpack_rgba_float(void *dst_row, unsigned dst_stride,
                                       const uint8_t *src_row, unsigned src_stride,
index e079da44a64ad469ecad50f9676325913a2135f9..3699e025290da8a0abcd3e02b08ad3dec27148ed 100644 (file)
@@ -82,6 +82,7 @@ def has_access(format):
     # We don't generate code for YUV formats, and many of the new ones lack
     # pack/unpack functions for softpipe/llvmpipe.
     noaccess_formats = [
+        'r1_unorm',
         'yv12',
         'yv16',
         'iyuv',