meson: Don't define HAVE_PTHREAD only on linux
authorJon Turney <jon.turney@dronecode.org.uk>
Mon, 13 Nov 2017 10:13:39 +0000 (10:13 +0000)
committerJon Turney <jon.turney@dronecode.org.uk>
Thu, 16 Nov 2017 13:51:25 +0000 (13:51 +0000)
I'm not sure of the reason for this. I don't see anything like this in
configure.ac

In include/c11/threads.h the cases are:

1) building for Windows -> threads_win32.h
2) HAVE_PTHREAD -> threads_posix.h
3) Not supported on this platform

So not defining HAVE_PTHREAD for anything not Windows just means we can't
build at all.

When we are building for Windows, I'm not sure if dependency('threads')
would ever find anything, or defining HAVE_PTHREAD has any effect, but avoid
defining it there, just in case.

Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
meson.build

index 7fdc3c280e6b77d98af849012b9103b17ee1fe64..383ebb366625edf9f26256db160a7eab35fdb3af 100644 (file)
@@ -668,7 +668,7 @@ endif
 # TODO: some of these may be conditional
 dep_zlib = dependency('zlib', version : '>= 1.2.3')
 dep_thread = dependency('threads')
-if dep_thread.found() and host_machine.system() == 'linux'
+if dep_thread.found() and host_machine.system() != 'windows'
   pre_args += '-DHAVE_PTHREAD'
 endif
 dep_elf = dependency('libelf', required : false)