pan/bi: Add bi_instruction printing

So we can debug the IR in memory before code emit has happened. We'd
like to have a complete dump of the IR -- neglecting this with Midgard
was one of those mistakes I've regretted so let's get this right for the
first time around.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4061>

diff --git a/src/panfrost/bifrost/bi_print.c b/src/panfrost/bifrost/bi_print.c
index ad82c3a2aed46cb00dac9185a52356eb6f51caea..a445eb4c41aaf799e2579d981b67d348d762c884 100644 (file)
--- a/src/panfrost/bifrost/bi_print.c
+++ b/src/panfrost/bifrost/bi_print.c
@@ -102,4 +102,229 @@ bi_ldst_type_name(enum bifrost_ldst_type type)
         }
 }
 
         }
 }
 

+/* The remaining functions in this file are for IR-internal
+ * structures; the disassembler doesn't use them */

 
 

+static const char *
+bi_class_name(enum bi_class cl)
+{
+        switch (cl) {
+        case BI_ADD: return "add";
+        case BI_ATEST: return "atest";
+        case BI_BRANCH: return "branch";
+        case BI_CMP: return "cmp";
+        case BI_BLEND: return "blend";
+        case BI_BITWISE: return "bitwise";
+        case BI_CONVERT: return "convert";
+        case BI_CSEL: return "csel";
+        case BI_DISCARD: return "discard";
+        case BI_EXTRACT: return "extract";
+        case BI_FMA: return "fma";
+        case BI_FREXP: return "frexp";
+        case BI_LOAD: return "load";
+        case BI_LOAD_ATTR: return "load_attr";
+        case BI_LOAD_VAR: return "load_var";
+        case BI_LOAD_VAR_ADDRESS: return "load_var_address";
+        case BI_MAKE_VEC: return "make_vec";
+        case BI_MINMAX: return "minmax";
+        case BI_MOV: return "mov";
+        case BI_SHIFT: return "shift";
+        case BI_STORE: return "store";
+        case BI_STORE_VAR: return "store_var";
+        case BI_SPECIAL: return "special";
+        case BI_SWIZZLE: return "swizzle";
+        case BI_TEX: return "tex";
+        case BI_ROUND: return "round";
+        default: return "unknown_class";
+        }
+}
+
+static void
+bi_print_src(FILE *fp, bi_instruction *ins, unsigned s)
+{
+        unsigned src = ins->src[s];
+        bool mods = bi_has_source_mods(ins);
+        bool abs = ins->src_abs[s] && mods;
+        bool neg = ins->src_neg[s] && mods;
+
+        if (neg)
+                fprintf(fp, "-");
+
+        if (abs)
+                fprintf(fp, "abs(");
+
+        if (!src)
+                fprintf(fp, "_");
+        else if (src & BIR_INDEX_REGISTER)
+                fprintf(fp, "br%u", src & ~BIR_INDEX_REGISTER);
+        else if (src & BIR_INDEX_UNIFORM)
+                fprintf(fp, "u%u", src & ~BIR_INDEX_UNIFORM);
+        else if (src & BIR_INDEX_CONSTANT)
+                fprintf(fp, "#0x%" PRIx64, ins->constant.u64);
+        else if (src & BIR_INDEX_ZERO)
+                fprintf(fp, "#0");
+        else if (src & BIR_IS_REG)
+                fprintf(fp, "r%u", src >> 1);
+        else
+                fprintf(fp, "%u", (src >> 1) - 1);
+
+        if (abs)
+                fprintf(fp, ")");
+}
+
+/* Prints a NIR ALU type in Bifrost-style ".f32" ".i8" etc */
+
+static void
+bi_print_alu_type(nir_alu_type t, FILE *fp)
+{
+        unsigned size = nir_alu_type_get_type_size(t);
+        nir_alu_type base = nir_alu_type_get_base_type(t);
+
+        switch (base) {
+        case nir_type_int:
+                fprintf(fp, ".i");
+                break;
+        case nir_type_uint:
+                fprintf(fp, ".u");
+                break;
+        case nir_type_bool:
+                fprintf(fp, ".b");
+                break;
+        case nir_type_float:
+                fprintf(fp, ".f");
+                break;
+        default:
+                fprintf(fp, ".unknown");
+                break;
+        }
+
+        fprintf(fp, "%u", size);
+}
+
+static void
+bi_print_swizzle(bi_instruction *ins, FILE *fp)
+{
+        unsigned size = nir_alu_type_get_type_size(ins->dest_type);
+        unsigned count = 32 / size;
+        assert(size == 8 || size == 16);
+
+        fprintf(fp, ".");
+
+        for (unsigned u = 0; u < count; ++u) {
+                assert(ins->swizzle[u] < size);
+                fputc("xyzw"[ins->swizzle[u]], fp);
+        }
+}
+
+static const char *
+bi_bitwise_op_name(enum bi_bitwise_op op)
+{
+        switch (op) {
+        case BI_BITWISE_AND: return "and";
+        case BI_BITWISE_OR: return "or";
+        case BI_BITWISE_XOR: return "xor";
+        default: return "invalid";
+        }
+}
+
+static void
+bi_print_load(struct bi_load *load, FILE *fp)
+{
+        fprintf(fp, ".loc%u", load->location);
+
+        if (load->channels != 1)
+                fprintf(fp, ".v%u", load->channels);
+}
+
+static void
+bi_print_load_vary(struct bi_load_vary *load, FILE *fp)
+{
+        bi_print_load(&load->load, fp);
+        fprintf(fp, "%s", bi_interp_mode_name(load->interp_mode));
+
+        if (load->reuse)
+                fprintf(fp, ".reuse");
+
+        if (load->flat)
+                fprintf(fp, ".flat");
+}
+
+static const char *
+bi_cond_name(enum bi_cond cond)
+{
+        switch (cond) {
+        case BI_COND_ALWAYS: return ".always";
+        case BI_COND_LT: return ".lt";
+        case BI_COND_LE: return ".le";
+        case BI_COND_GE: return ".ge";
+        case BI_COND_GT: return ".gt";
+        case BI_COND_EQ: return ".eq";
+        case BI_COND_NE: return ".ne";
+        default: return "invalid";
+        }
+}
+
+static void
+bi_print_branch(struct bi_branch *branch, FILE *fp)
+{
+        fprintf(fp, "%s", bi_cond_name(branch->cond));
+}
+
+void
+bi_print_instruction(bi_instruction *ins, FILE *fp)
+{
+        if (ins->type == BI_MINMAX)
+                fprintf(fp, "%s", ins->op.minmax == BI_MINMAX_MIN ? "min" : "max");
+        else if (ins->type == BI_BITWISE)
+                fprintf(fp, "%s", bi_bitwise_op_name(ins->op.bitwise));
+        else if (ins->type == BI_ROUND)
+                fprintf(fp, ins->op.round == BI_ROUND_MODE ? "roundMode": "round");
+        else
+                fprintf(fp, "%s", bi_class_name(ins->type));
+
+        if (ins->type == BI_MINMAX)
+                fprintf(fp, "%s", bi_minmax_mode_name(ins->minmax));
+        else if (ins->type == BI_LOAD_ATTR || ins->type == BI_LOAD_VAR_ADDRESS)
+                bi_print_load(&ins->load, fp);
+        else if (ins->type == BI_LOAD_VAR)
+                bi_print_load_vary(&ins->load_vary, fp);
+        else if (ins->type == BI_BRANCH)
+                bi_print_branch(&ins->branch, fp);
+        else if (ins->type == BI_CSEL)
+                fprintf(fp, "%s", bi_cond_name(ins->csel_cond));
+
+        if (ins->dest)
+                bi_print_alu_type(ins->dest_type, fp);
+
+        if (bi_has_outmod(ins))
+                fprintf(fp, "%s", bi_output_mod_name(ins->outmod));
+
+        if (bi_class_props[ins->type] & BI_ROUNDMODE)
+                fprintf(fp, "%s", bi_round_mode_name(ins->roundmode));
+
+        fprintf(fp, " ");
+
+        if (ins->dest)
+                fprintf(fp, "%d", ins->dest);
+        else
+                fprintf(fp, "_");
+
+        fprintf(fp, ", ");
+
+        bi_foreach_src(ins, s) {
+                bi_print_src(fp, ins, s);
+
+                if (bi_is_src_swizzled(ins, s))
+                        bi_print_swizzle(ins, fp);
+
+                if (ins->type == BI_CONVERT && s == 0)
+                        bi_print_alu_type(ins->src_types[s], fp);
+                else if ((ins->type == BI_BRANCH || ins->type == BI_CSEL) && s < 2)
+                        bi_print_alu_type(ins->src_types[s], fp);
+
+                if (s < BIR_SRC_COUNT)
+                        fprintf(fp, ", ");
+        }
+
+        fprintf(fp, "\n");
+}

diff --git a/src/panfrost/bifrost/bi_print.h b/src/panfrost/bifrost/bi_print.h
index fa12fb8031f1b70983860351e7a54ebe33dd6ac5..cc2689afae235fe294621f0617792165b1805240 100644 (file)
--- a/src/panfrost/bifrost/bi_print.h
+++ b/src/panfrost/bifrost/bi_print.h
@@ -27,7 +27,9 @@
 #ifndef __BI_PRINT_H
 #define __BI_PRINT_H
 
 #ifndef __BI_PRINT_H
 #define __BI_PRINT_H
 

+#include <stdio.h>

 #include "bifrost.h"
 #include "bifrost.h"

+#include "compiler.h"

 
 const char * bi_output_mod_name(enum bifrost_outmod mod);
 const char * bi_minmax_mode_name(enum bifrost_minmax_mode mod);
 
 const char * bi_output_mod_name(enum bifrost_outmod mod);
 const char * bi_minmax_mode_name(enum bifrost_minmax_mode mod);


@@ -36,4 +38,6 @@ const char * bi_csel_cond_name(enum bifrost_csel_cond cond);
 const char * bi_interp_mode_name(enum bifrost_interp_mode mode);
 const char * bi_ldst_type_name(enum bifrost_ldst_type type);
 
 const char * bi_interp_mode_name(enum bifrost_interp_mode mode);
 const char * bi_ldst_type_name(enum bifrost_ldst_type type);
 

+void bi_print_instruction(bi_instruction *ins, FILE *fp);
+

 #endif
 #endif