radeonsi/gfx9: fix crash building monolithic merged ES-GS shader
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Wed, 12 Jul 2017 13:38:57 +0000 (15:38 +0200)
committerNicolai Hähnle <nicolai.haehnle@amd.com>
Thu, 13 Jul 2017 11:01:15 +0000 (13:01 +0200)
Forwarding from the ES prolog to the ES just barely exceeds the current
maximum array size when 16 vertex attributes are used. Give it a decent
bump to account for merged shaders having up to 32 user SGPRs.

Fixes a crash in GL45-CTS.multi_bind.draw_bind_vertex_buffers.

Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/radeonsi/si_shader.c

index 349e57b3a98a592f72d2356102f6586dc185f886..4c0cda58fb7b46c5677cd125cbff42a594f668d3 100644 (file)
@@ -5892,9 +5892,11 @@ static void si_build_wrapper_function(struct si_shader_context *ctx,
 {
        struct gallivm_state *gallivm = &ctx->gallivm;
        LLVMBuilderRef builder = ctx->gallivm.builder;
-       /* PS epilog has one arg per color component */
-       LLVMTypeRef param_types[48];
-       LLVMValueRef initial[48], out[48];
+       /* PS epilog has one arg per color component; gfx9 merged shader
+        * prologs need to forward 32 user SGPRs.
+        */
+       LLVMTypeRef param_types[64];
+       LLVMValueRef initial[64], out[64];
        LLVMTypeRef function_type;
        unsigned num_params;
        unsigned num_out, initial_num_out;
@@ -6114,6 +6116,7 @@ static void si_build_wrapper_function(struct si_shader_context *ctx,
                                LLVMValueRef val =
                                        LLVMBuildExtractValue(builder, ret, i, "");
 
+                               assert(num_out < ARRAY_SIZE(out));
                                out[num_out++] = val;
 
                                if (LLVMTypeOf(val) == ctx->i32) {