mesa: remove unrequired double calc
authorTimothy Arceri <tarceri@itsqueeze.com>
Tue, 23 May 2017 12:01:53 +0000 (22:01 +1000)
committerTimothy Arceri <tarceri@itsqueeze.com>
Thu, 25 May 2017 02:20:57 +0000 (12:20 +1000)
type_size() will already handle this correctly for us.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/mesa/program/ir_to_mesa.cpp

index 3299ab722a216a5ac52e0e00de12d67977c0f8e4..4c30bea2f2347b1478f6edfa018b480929304a21 100644 (file)
@@ -2445,20 +2445,10 @@ add_uniform_to_shader::visit_field(const glsl_type *type, const char *name,
                                    const enum glsl_interface_packing,
                                    bool /* last_field */)
 {
-   unsigned int size;
-
    /* atomics don't get real storage */
    if (type->contains_atomic())
       return;
 
-   if (type->is_vector() || type->is_scalar()) {
-      size = type->vector_elements;
-      if (type->is_64bit())
-         size *= 2;
-   } else {
-      size = type_size(type) * 4;
-   }
-
    gl_register_file file;
    if (type->without_array()->is_sampler()) {
       file = PROGRAM_SAMPLER;
@@ -2468,6 +2458,8 @@ add_uniform_to_shader::visit_field(const glsl_type *type, const char *name,
 
    int index = _mesa_lookup_parameter_index(params, name);
    if (index < 0) {
+      unsigned size = type_size(type) * 4;
+
       index = _mesa_add_parameter(params, file, name, size, type->gl_type,
                                  NULL, NULL);