broadcom/vc5: Drop the finished_seqno optimization.
authorEric Anholt <eric@anholt.net>
Wed, 4 Apr 2018 16:58:23 +0000 (09:58 -0700)
committerEric Anholt <eric@anholt.net>
Thu, 12 Apr 2018 18:20:50 +0000 (11:20 -0700)
With the DRM scheduler changes, I'm about to remove all seqnos from the
UABI.

src/gallium/drivers/vc5/vc5_bufmgr.c
src/gallium/drivers/vc5/vc5_screen.h

index 5e068400fd81dc12f4473e9a2f809a111f26aa72..bced512ae0d03bda6fcc6591d3e33207bf5707f8 100644 (file)
@@ -469,9 +469,6 @@ bool
 vc5_wait_seqno(struct vc5_screen *screen, uint64_t seqno, uint64_t timeout_ns,
                const char *reason)
 {
-        if (screen->finished_seqno >= seqno)
-                return true;
-
         if (unlikely(V3D_DEBUG & V3D_DEBUG_PERF) && timeout_ns && reason) {
                 if (vc5_wait_seqno_ioctl(screen->fd, seqno, 0) == -ETIME) {
                         fprintf(stderr, "Blocking on seqno %lld for %s\n",
@@ -489,7 +486,6 @@ vc5_wait_seqno(struct vc5_screen *screen, uint64_t seqno, uint64_t timeout_ns,
                 return false;
         }
 
-        screen->finished_seqno = seqno;
         return true;
 }
 
index 710396de999ad721ce8cf5cf3516c2d2f0c93864..05a770ba2a18e2fe8e548ee71e3e64cb7904a7f2 100644 (file)
@@ -61,13 +61,6 @@ struct vc5_screen {
 
         const char *name;
 
-        /** The last seqno we've completed a wait for.
-         *
-         * This lets us slightly optimize our waits by skipping wait syscalls
-         * if we know the job's already done.
-         */
-        uint64_t finished_seqno;
-
         struct slab_parent_pool transfer_pool;
 
         struct vc5_bo_cache {