gallium/radeon: consolidate PIPE_BIND_SHARED/SCANOUT handling
authorMarek Olšák <marek.olsak@amd.com>
Mon, 18 Sep 2017 16:04:25 +0000 (18:04 +0200)
committerMarek Olšák <marek.olsak@amd.com>
Wed, 27 Sep 2017 08:38:46 +0000 (10:38 +0200)
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
src/gallium/drivers/radeon/r600_buffer_common.c
src/gallium/drivers/radeon/r600_texture.c

index 706c7485c353bc616275b22d55e84ebdac9da9a3..b3e60a46e436d3c90df4759bc4885d5a7d62d4a2 100644 (file)
@@ -167,12 +167,10 @@ void si_init_resource_fields(struct r600_common_screen *rscreen,
                         RADEON_FLAG_GTT_WC;
        }
 
-       /* Only displayable single-sample textures can be shared between
-        * processes. */
-       if (!(res->b.b.bind & (PIPE_BIND_SHARED | PIPE_BIND_SCANOUT)) &&
-           (res->b.b.target == PIPE_BUFFER ||
-            res->b.b.nr_samples >= 2 ||
-            rtex->surface.micro_tile_mode != RADEON_MICRO_MODE_DISPLAY))
+       /* Displayable and shareable surfaces are not suballocated. */
+       if (res->b.b.bind & (PIPE_BIND_SHARED | PIPE_BIND_SCANOUT))
+               res->flags |= RADEON_FLAG_NO_SUBALLOC; /* shareable */
+       else
                res->flags |= RADEON_FLAG_NO_INTERPROCESS_SHARING;
 
        /* If VRAM is just stolen system memory, allow both VRAM and
@@ -192,9 +190,6 @@ void si_init_resource_fields(struct r600_common_screen *rscreen,
        if (rscreen->debug_flags & DBG_NO_WC)
                res->flags &= ~RADEON_FLAG_GTT_WC;
 
-       if (res->b.b.bind & PIPE_BIND_SHARED)
-               res->flags |= RADEON_FLAG_NO_SUBALLOC;
-
        /* Set expected VRAM and GART usage for the buffer. */
        res->vram_usage = 0;
        res->gart_usage = 0;
index 829d1058271a7da01da9c83f728061c78b14639c..a9a1b2627e596e060691b8d3ee4822bd837a42c4 100644 (file)
@@ -1219,10 +1219,6 @@ r600_texture_create_object(struct pipe_screen *screen,
                si_init_resource_fields(rscreen, resource, rtex->size,
                                          rtex->surface.surf_alignment);
 
-               /* Displayable surfaces are not suballocated. */
-               if (resource->b.b.bind & PIPE_BIND_SCANOUT)
-                       resource->flags |= RADEON_FLAG_NO_SUBALLOC;
-
                if (!si_alloc_resource(rscreen, resource)) {
                        FREE(rtex);
                        return NULL;