comment where PermissionValidator needed
authorLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Sun, 21 Apr 2019 07:26:07 +0000 (08:26 +0100)
committerLuke Kenneth Casson Leighton <lkcl@lkcl.net>
Sun, 21 Apr 2019 07:26:07 +0000 (08:26 +0100)
TLB/src/ariane/mmu.py

index 0cc04dbb6756d608b86313da72f698cb29fc36f9..a5c27a9e278814344550e5a7f3e07476fd2ef862 100644 (file)
@@ -231,10 +231,12 @@ class MMU:
         m.d.comb += icache_areq_o.fetch_exception.eq(0)
         # Check whether we are allowed to access this memory region
         # from a fetch perspective
+
+        # XXX TODO: use PermissionValidator instead [we like modules]
         m.d.comb += iaccess_err.eq(icache_areq_i.fetch_req & \
                                    (((priv_lvl_i == PRIV_LVL_U) & \
                                       ~itlb_content.u) | \
-                                   ((priv_lvl_i == :PRIV_LVL_S) & \
+                                   ((priv_lvl_i == PRIV_LVL_S) & \
                                     itlb_content.u)))
 
         # MMU enabled: address from TLB, request delayed until hit.